feat(lint): support object method in noFloatingPromises

[kaykdm]

Summary

#4956
This pull request introduces the support for object methods in noFloatingPromises

Example of invalid code:

calling an async method in the same object using this

const obj = {
  returnsPromiseArrowFunction: async (): Promise<string> => {
    return "value";
  },

  returnsPromiseFunction: async function (): Promise<string> {
    return "value";
  },

  async returnsPromiseMethod(): Promise<string> {
    return "value";
  },

  someMethod() {
    this.returnsPromiseArrowFunction();  // diagnostic here
    this.returnsPromiseFunction().then(() => {});  // diagnostic here
    this.returnsPromiseMethod();  // diagnostic here
  }
};

calling an async method from outside

const obj = {
  returnsPromiseArrowFunction: async (): Promise<string> => {
    return "value";
  },

  returnsPromiseFunction: async function (): Promise<string> {
    return "value";
  },

  async returnsPromiseMethod(): Promise<string> {
    return "value";
  },
};

obj.returnsPromiseArrowFunction();  // diagnostic here
obj.returnsPromiseFunction().then(() => {});  // diagnostic here
obj['returnsPromiseMethod']();  // diagnostic here

Example of valid code:

const obj = {
  returnsPromiseArrowFunction: async (): Promise<string> => {
    return "value";
  },

  returnsPromiseFunction: async function (): Promise<string> {
    return "value";
  },

  async returnsPromiseMethod(): Promise<string> {
    return "value";
  },

  async someMethod() {
    await this.returnsPromiseArrowFunction();
    this.returnsPromiseFunction().then(() => {}, () => {});
    this.returnsPromiseMethod().catch(() => {});
  }
};

await obj.returnsPromiseArrowFunction();
await obj['returnsPromiseFunction']();

[codspeed-hq]

CodSpeed Performance Report

Merging #5103 will not alter performance

_{Comparing kaykdm:support-object-method (43745b2) with main (bca10f5)}

Summary

✅ 94 untouched benchmarks