Add curie query support (mychem version) #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
February 5, 2024 15:57
Also separate the settings into a separate file for isolating the configuration from client construction methods
Specifically targets _getannotation and _getannotations methods at the moment and only for the mygene instance
Not all of the different sites will work with that. Ran into issues with that default pattern with myvariant. Instead we should view this feature as specifically targetting support for the biolink prefixes and nothing else
Pivot to adding testing and verification that the API / server side implementation supports the CURIE ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for verifying that the CURIE ID support works for the mychem repository for the subset of queries we support from the biolink model