-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DEFAULT_CONF_DIRS
to the minimal components required to deploy the stack
#399
Changes from all commits
b5bc400
357da73
a699efb
66ee207
35a8da3
7a2a627
1c02991
914f2ea
6517fd3
8a66b2e
95aa509
efd7e4c
f47480e
9100600
a1a1d05
e424083
227a028
39e7a6c
adbd1f5
1e32bcf
5ea5106
a7f1b81
9ff694a
48e6f21
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
1.42.2 2023-12-08T18:02:01Z | ||
2.0.0 2023-12-11T14:46:41Z |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
./config | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we are purposely moving components, should we consider leaving this un-ignored? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we have to ignore it so that the autoupdate code works. Right @tlvu ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since it would be a major update that could remove components if misconfigured, I guess it that it would feel safer to purposely break the autoupdate to have node admins make sure they set up their There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not either so let's let @tlvu decide this one There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd rather prefer not breaking the autodeploy. We had already the plan to do this: add the new paths in advance to However I would also ping PCIC in this PR so they are aware of this major change. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
version: "3.4" | ||
services: | ||
proxy: | ||
volumes: | ||
- ./components/canarie-api/config/proxy/conf.extra-service.d:/etc/nginx/conf.extra-service.d/canarie-api:ro | ||
- ./components/canarie-api/docker_configuration.py:/config/docker_configuration.py | ||
- ./components/canarie-api/entrypoint:/entrypoint:ro | ||
environment: | ||
CANARIE_API_CONFIG_FN: /config/docker_configuration.py | ||
CANARIE_MONITORING_EXTRA_CONF_DIR: ${CANARIE_MONITORING_EXTRA_CONF_DIR} | ||
entrypoint: /entrypoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that
./components/jupyterhub
is not enabled by default anymore, but./components/stac
is, it might be worth mentioning that addingPROXY_ROOT_LOCATION
explicitly could be required depending on which components are enabled, and which one the node manager desires to put as default redirect (if any).