Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the marble image to notebook images list #427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding the marble image to notebook images list #427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions birdhouse/env.local.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,8 @@ export GEOSERVER_ADMIN_PASSWORD="${__DEFAULT__GEOSERVER_ADMIN_PASSWORD}"
#export ALLOW_UNSECURE_HTTP=""

# Jupyter single-user server images
#export DOCKER_NOTEBOOK_IMAGES="pavics/workflow-tests:210216 \
#export DOCKER_NOTEBOOK_IMAGES="marbleclimate/marble-jupyter-images \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this hosted? I cannot find them on DockerHub (default for docker pull). Is it on a private/other registry?
If a user enables this as is without appropriate docker login to the appropriate registry, that will make the deployment fail due to unresolved reference, unless the Jupyter config is overridden here to allow missing dockers :

birdhouse-deploy/birdhouse/components/jupyterhub/jupyterhub_config.py.template

Line 181 in eaa09c2

c.DockerSpawner.pull_policy = "always" # for images not using pinned version

Also, just to make sure, is the trailing s of the image a typo? Is it a single docker image using this name explicitly? Images should be listed individually here.

# pavics/workflow-tests:210216 \
# pavics/crim-jupyter-eo:0.3.0 \
# pavics/crim-jupyter-nlp:0.4.0 \
# birdhouse/pavics-jupyter-base:mlflow-proxy"
Expand All @@ -274,7 +275,8 @@ export GEOSERVER_ADMIN_PASSWORD="${__DEFAULT__GEOSERVER_ADMIN_PASSWORD}"
# Note that the selection names are also used as directory names for the tutorial-notebooks directories mounted when
# starting the corresponding image. The name can use the '<name>' or the '<name>:<version>' format. The version will be
# excluded when mounting the corresponding directory.
#export JUPYTERHUB_IMAGE_SELECTION_NAMES="pavics \
#export JUPYTERHUB_IMAGE_SELECTION_NAMES="marble \
# pavics \
# eo-crim:0.3.0 \
# nlp-crim \
# mlflow-crim"
Expand Down
Loading