Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables, constants and files from PAVICS to Birdhouse #428

Merged
merged 56 commits into from
Jun 4, 2024

Conversation

mishaschwartz
Copy link
Collaborator

@mishaschwartz mishaschwartz commented Mar 1, 2024

Overview

For historical reasons the name PAVICS was used in variable names, constants and filenames in this repo to refer
to the software stack in general. This was because, for a long time, the PAVICS deployment of this stack was the
only one that was being used in production. However, now that multiple deployments of this software exist in
production (that are not named PAVICS), we remove unnecessary references to PAVICS in order to reduce confusion
for maintainers and developers who may not be aware of the historical reasons for the PAVICS name.

This update makes the following changes:

  • The string PAVICS in environment variables, constant values, and file names have been changed to
    BIRDHOUSE (case has been preserved where possible).
    • For example:
      • PAVICS_FQDN -> BIRDHOUSE_FQDN
      • pavics_compose.sh -> birdhouse_compose.sh
      • THREDDS_DATASET_LOCATION_ON_CONTAINER='/pavics-ncml' -> THREDDS_DATASET_LOCATION_ON_CONTAINER='/birdhouse-ncml'
  • Comment strings and documentation that refers to the software stack as PAVICS have been changed to use
    Birdhouse.
  • Recreated the pavics-compose.sh script that runs birdhouse-compose.sh in backwards compatible mode.
    • Backwards compatible mode means that variables in env.local that contain the string PAVICS will be used
      to set the equivalent variable that contains BIRDHOUSE. For example, the PAVICS_FQDN variable set in
      the env.local file will be used to set the value of BIRDHOUSE_FQDN.
  • Create a new entrypoint in bin/birdhouse that can be used to invoke pavics-compose.sh or
    birdhouse-compose.sh from one convenient location. This script also includes some useful options and provides
    a generic entrypoint to the stack that can be extended in the future.
  • Removed unused variables:
    • CMIP5_THREDDS_ROOT

Migration Guide

  • Update env.local file to replace all variables that contain PAVICS with BIRDHOUSE.
    Variable names have also been updated to ensure that they start with the prefix BIRDHOUSE_.

    • see env.local.example to see new variable names
    • see the BACKWARDS_COMPATIBLE_VARIABLES variable (defined in default.env) for a
      full list of changed environment variable names.
  • Update any external scripts that access the old variable names directly to use the updated variable names.

  • Update any external scripts that access any of the following files to use the new file name:

    old file name new file name
    pavics-compose.sh birdhouse-compose.sh
    PAVICS-deploy.logrotate birdhouse-deploy.logrotate
    configure-pavics.sh configure-birdhouse.sh
    trigger-pavicscrawler trigger-birdhousecrawler
  • The following default values have changed. If your deployment was using the old default value, update your
    env.local file to explicitly set the old default values.

    old variable name new variable name old default value new default value
    POSTGRES_PAVICS_USERNAME BIRDHOUSE_POSTGRES_USERNAME postgres-pavics postgres-birdhouse
    THREDDS_DATASET_LOCATION_ON_CONTAINER (no change) /pavics-ncml /birdhouse-datasets
    THREDDS_SERVICE_DATA_LOCATION_ON_CONTAINER (no change) /pavics-data /birdhouse-service-data
    THREDDS_DATASET_LOCATION_ON_HOST (no change) '${DATA_PERSIST_ROOT}/ncml' '${BIRDHOUSE_DATA_PERSIST_ROOT}/thredds-datasets'
    THREDDS_SERVICE_DATA_LOCATION_ON_HOST (no change) '${DATA_PERSIST_ROOT}/datasets' '${BIRDHOUSE_DATA_PERSIST_ROOT}/thredds-service-data'
    (hardcoded) BIRDHOUSE_POSTGRES_DB pavics birdhouse
    PAVICS_LOG_DIR BIRDHOUSE_LOG_DIR /var/log/PAVICS /var/log/birdhouse
    (hardcoded) GRAFANA_DEFAULT_PROVIDER_FOLDER Local-PAVICS Local-Birdhouse
    (hardcoded) GRAFANA_DEFAULT_PROVIDER_FOLDER_UUID local-pavics local-birdhouse
    (hardcoded) GRAFANA_PROMETHEUS_DATASOURCE_UUID local_pavics_prometheus local_birdhouse_prometheus
  • Update any jupyter notebooks that make use of the PAVICS_HOST_URL environment variable to use the new
    BIRDHOUSE_HOST_URL instead.

  • Set the BIRDHOUSE_POSTGRES_DB variable to pavics in the env.local file. This value was previously
    hardcoded to the string pavics so to maintain backwards compatibility with any existing databases this should be
    kept the same. If you do want to update to the new database name, you will need to rename the existing database.
    For example, the following will update the existing database named pavics to birdhouse (assuming the old
    default values for the postgres username):

    docker exec -it postgres psql -U postgres-pavics -d postgres -c 'ALTER DATABASE pavics RENAME TO birdhouse'

    You can then update the env.local file to the new variable name and restart the stack

  • Set the BIRDHOUSE_POSTGRES_USER variable to postgres-pavics in the env.local file if you would like to
    preserve the old default value. If you would like to change the value of BIRDHOUSE_POSTGRES_USER then also
    update the name for any running postgres instances. For example, the following will update the user named
    postgres-pavics to postgres-birdhouse:

    docker exec -it postgres psql -U postgres-pavics -d postgres -c 'CREATE USER "tmpsuperuser" WITH SUPERUSER'
    docker exec -it postgres psql -U tmpsuperuser -d postgres -c 'ALTER ROLE "postgres-pavics" RENAME TO "postgres-birdhouse"'
    docker exec -it postgres psql -U tmpsuperuser -d postgres -c 'ALTER ROLE "postgres-birdhouse" WITH PASSWORD '\''postgres-qwerty'\'
    docker exec -it postgres psql -U postgres-birdhouse -d postgres -c 'DROP ROLE "tmpsuperuser"'

    Note that the postgres-qwerty value is meant just for illustration, you should replace this with the value of
    the BIRDHOUSE_POSTGRES_PASSWORD variable.
    Note that you'll need to do the same for the stac-db service as well (assuming that you weren't previously
    overriding the STAC_POSTGRES_USER with a custom value).

Changes

Non-breaking changes

  • comment changes
  • most changes are backwards compatible (but not all)

Breaking changes

  • variable, file, constant name changes

Related Issue / Discussion

Additional Information

Links to other issues or sources.

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false

@github-actions github-actions bot added ci/deployment Related to deployment utilities and scripts ci/operations Continuous Integration components ci/tests Issues or changes related to tests scripts component/cowbird Related to https://github.com/Ouranosinc/cowbird component/geoserver Related to GeoServer or one of its underlying services component/jupyterhub Related to JupyterHub as development frontend with notebooks component/magpie Related to https://github.com/Ouranosinc/Magpie component/STAC Features or components related to STAC component/THREDDS Features or components related to THREDDS component/twitcher Related to https://github.com/bird-house/twitcher component/weaver Related to https://github.com/crim-ca/weaver documentation Improvements or additions to documentation feature/node-registry Related to https://github.com/DACCS-Climate/DACCS-node-registry feature/WPS Feature or service related to Web Processing Service labels Mar 1, 2024
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with the organization name (https://github.com/bird-house), I think the comment/doc mentions should be formatted either as bird-house or Bird-House instead of Birdhouse.

In the PR description, the relative file link do not work.

birdhouse/default.env Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated
Comment on lines 44 to 49
- Update ``env.local`` file to replace all variables that contain ``PAVICS`` with ``BIRDHOUSE``.
* see [`env.local.example`](./birdhouse/env.local.example) to see new variable names
* see the ``BACKWARDS_COMPATIBLE_VARIABLES_PAVICS`` variable (defined in
[`default.env`](./birdhouse/default.env)) for a full list of changed environment variable names.
- Update any external scripts that access the old variable names directly to use the updated variable names.
- Update any external scripts that access any of the following files to use the new file name:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these mandatory changes or recommended ones provided the backwards compatible mode mentioned above?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's recommended. But since this is a migration guide, this is one of the steps to migrate properly. In the future, if we drop support for the old variable names we don't want people to lose out because they didn't migrate properly.

CHANGES.md Outdated Show resolved Hide resolved
CONTRIBUTING.rst Show resolved Hide resolved
docs/source/conf.py Show resolved Hide resolved
docs/source/conf.py Show resolved Hide resolved
tests/test_read_configs_include.py Show resolved Hide resolved
birdhouse/env.local.example Outdated Show resolved Hide resolved
birdhouse/default.env Show resolved Hide resolved
@tlvu
Copy link
Collaborator

tlvu commented May 23, 2024

@tlvu this PR has been tested with autodeploy: from master to this branch, and from this branch to a future update

I let @tlvu see if anything else still needs to be addressed.

@mishaschwartz @fmigneault yes my bad, extremely sorry. I was too consumed lately on other issues on Ouranos side. If I can not get to this next week, I think you can merge and new findings from me will just be in a followup PR.

@mishaschwartz
Copy link
Collaborator Author

@tlvu

Ok thanks for the follow up. I'll aim to merge this on Friday May 31st if you haven't had a chance to look at it before then.

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2666/
ResultSUCCESS

BIRDHOUSE_DEPLOY_BRANCH : pavics-to-birdhouse
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-118.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1614/

NOTEBOOK TEST RESULTS
    
[2024-05-27T13:43:14.389Z] ============================= test session starts ==============================
[2024-05-27T13:43:14.389Z] platform linux -- Python 3.11.6, pytest-8.2.0, pluggy-1.5.0
[2024-05-27T13:43:14.389Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2024-05-27T13:43:14.389Z] plugins: anyio-4.3.0, dash-2.17.0, nbval-0.11.0, tornasync-0.6.0.post2, xdist-3.5.0
[2024-05-27T13:43:14.389Z] collected 275 items
[2024-05-27T13:43:14.389Z] 
[2024-05-27T13:43:23.377Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-05-27T13:43:42.315Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-05-27T13:43:50.176Z] notebooks-auth/test_thredds.ipynb ...........                            [ 14%]
[2024-05-27T13:44:35.334Z] pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb ......          [ 16%]
[2024-05-27T13:44:43.987Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 18%]
[2024-05-27T13:44:52.393Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 21%]
[2024-05-27T13:45:01.140Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 24%]
[2024-05-27T13:52:11.342Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 28%]
[2024-05-27T13:52:11.342Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 28%]
[2024-05-27T13:52:19.199Z] ...............                                                          [ 34%]
[2024-05-27T13:52:26.905Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 36%]
[2024-05-27T13:52:34.596Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 38%]
[2024-05-27T13:52:48.473Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 40%]
[2024-05-27T13:52:54.569Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 42%]
[2024-05-27T13:52:58.910Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 44%]
[2024-05-27T13:56:37.403Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 50%]
[2024-05-27T13:57:47.987Z] .............                                                            [ 54%]
[2024-05-27T13:57:50.686Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 56%]
[2024-05-27T13:57:52.457Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 59%]
[2024-05-27T13:58:07.287Z] .................                                                        [ 65%]
[2024-05-27T13:58:14.742Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 67%]
[2024-05-27T13:58:15.687Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 68%]
[2024-05-27T13:58:33.484Z] .........                                                                [ 71%]
[2024-05-27T13:58:42.521Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 75%]
[2024-05-27T13:58:52.321Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 77%]
[2024-05-27T13:58:53.706Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 77%]
[2024-05-27T13:58:56.793Z] .....                                                                    [ 79%]
[2024-05-27T13:59:11.686Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 80%]
[2024-05-27T13:59:28.290Z] ............                                                             [ 84%]
[2024-05-27T13:59:43.225Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 84%]
[2024-05-27T14:00:03.005Z] .....s.                                                                  [ 87%]
[2024-05-27T14:00:11.148Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 87%]
[2024-05-27T14:00:25.022Z] ..                                                                       [ 88%]
[2024-05-27T14:00:39.933Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 88%]
[2024-05-27T14:01:34.222Z] ........                                                                 [ 91%]
[2024-05-27T14:01:44.240Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-6Regridding_Conversion.ipynb . [ 92%]
[2024-05-27T14:06:34.903Z] ....                                                                     [ 93%]
[2024-05-27T14:06:34.903Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2024-05-27T14:08:58.109Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-05-27T14:08:58.109Z] 
[2024-05-27T14:08:58.109Z] =============================== warnings summary ===============================
    
  

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2669/
ResultSUCCESS

BIRDHOUSE_DEPLOY_BRANCH : pavics-to-birdhouse
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-118.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1615/

NOTEBOOK TEST RESULTS
    
[2024-05-29T12:32:48.429Z] ============================= test session starts ==============================
[2024-05-29T12:32:48.429Z] platform linux -- Python 3.11.6, pytest-8.2.0, pluggy-1.5.0
[2024-05-29T12:32:48.429Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2024-05-29T12:32:48.429Z] plugins: anyio-4.3.0, dash-2.17.0, nbval-0.11.0, tornasync-0.6.0.post2, xdist-3.5.0
[2024-05-29T12:32:48.429Z] collected 275 items
[2024-05-29T12:32:48.429Z] 
[2024-05-29T12:32:57.741Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-05-29T12:33:18.635Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-05-29T12:33:26.579Z] notebooks-auth/test_thredds.ipynb ...........                            [ 14%]
[2024-05-29T12:34:12.562Z] pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb ......          [ 16%]
[2024-05-29T12:34:21.237Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 18%]
[2024-05-29T12:34:29.344Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 21%]
[2024-05-29T12:34:38.632Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 24%]
[2024-05-29T12:42:02.361Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 28%]
[2024-05-29T12:42:02.362Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 28%]
[2024-05-29T12:42:06.836Z] ...............                                                          [ 34%]
[2024-05-29T12:42:14.530Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 36%]
[2024-05-29T12:42:21.204Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 38%]
[2024-05-29T12:42:35.076Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 40%]
[2024-05-29T12:42:42.180Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 42%]
[2024-05-29T12:42:46.420Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 44%]
[2024-05-29T12:46:11.956Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 50%]
[2024-05-29T12:47:22.006Z] .............                                                            [ 54%]
[2024-05-29T12:47:23.470Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 56%]
[2024-05-29T12:47:24.951Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 59%]
[2024-05-29T12:47:40.212Z] .................                                                        [ 65%]
[2024-05-29T12:47:47.163Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 67%]
[2024-05-29T12:47:48.553Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 68%]
[2024-05-29T12:48:05.820Z] .........                                                                [ 71%]
[2024-05-29T12:48:14.367Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 75%]
[2024-05-29T12:48:23.364Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 77%]
[2024-05-29T12:48:24.754Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 77%]
[2024-05-29T12:48:27.826Z] .....                                                                    [ 79%]
[2024-05-29T12:48:42.739Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 80%]
[2024-05-29T12:48:58.352Z] ............                                                             [ 84%]
[2024-05-29T12:49:13.280Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 84%]
[2024-05-29T12:49:33.439Z] .....s.                                                                  [ 87%]
[2024-05-29T12:49:40.015Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 87%]
[2024-05-29T12:49:54.816Z] ..                                                                       [ 88%]
[2024-05-29T12:50:09.731Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 88%]
[2024-05-29T12:51:04.060Z] ........                                                                 [ 91%]
[2024-05-29T12:51:14.076Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-6Regridding_Conversion.ipynb . [ 92%]
[2024-05-29T12:55:57.716Z] ....                                                                     [ 93%]
[2024-05-29T12:55:57.716Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2024-05-29T12:58:30.491Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-05-29T12:58:30.491Z] 
[2024-05-29T12:58:30.491Z] =============================== warnings summary ===============================
    
  

@mishaschwartz
Copy link
Collaborator Author

mishaschwartz commented May 31, 2024

@fmigneault

I'd appreciate your opinion:

I'm tempted to bump this a major version since:

MAJOR version when the API or user facing UI changes that requires significant documentation update

And the documentation has significantly changed even though the UI hasn't been changed at all. But that's not strictly necessary because everything should be fully backwards compatible. What do you think?

@tlvu
Copy link
Collaborator

tlvu commented May 31, 2024

I'm tempted to bump this a major version

I am doing code only quick review today, not enough time to perform a real deploy review. I'll let you know from a fresh eye perspective that not see how extensive this change is.

Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick read this PR, let me summarize what I understood, @mishaschwartz please correct me if I am wrong.

So all the old config vars name will still work if we have an an existing working env.local file, the back-compat mode is enabled by default.

If we have external script outside of this repo calling pavics-compose.sh and/or sourcing read-configs.include.sh they will still work transparently.

Very glad and very appreciate the effort put in to ensure this back-compat.

Now the breaking part: some old default values have changed. So even if the old config var name still work, their default value have changed.

So for vars that we never had to set in env.local because we were relying on the old default values, we now have to set them to get back the default values.

@fmigneault could I have the list of vars you had to set to keep the github pipeline and all your existing hosts running? I will use this as a starting point to adapt my env.local in advance so the day this PR goes live, my production host is already ready and the go-live can be automated and unattended. This list should be probably added to the migration doc (the changed log) to help other (ex: PCIC) prepare their env.local in advance.

I found a few items, nothing major.

And about the major version bump, I am not against, since some manual intervention is required but can be done in advanced so the go-live is still automated and unattended.

------

Power Analytics and Visualization for Climate Science - Powered by Birdhouse and other ESGF software
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the goal of the stack is still "Analytics and Visualization for Climate Science". Can we just keep that part of the string and only drop the rest?

birdhouse/components/README.rst Show resolved Hide resolved
birdhouse/components/cowbird/default.env Show resolved Hide resolved
export THREDDS_SERVICE_DATA_LOCATION_NAME='Birdhouse' # this default is for backward compatibility
export THREDDS_DATASET_URL_PATH='datasets' # this default is for backward compatibility
export THREDDS_SERVICE_DATA_URL_PATH='birdhouse' # this default is for backward compatibility
export THREDDS_DATASET_LOCATION_ON_CONTAINER='/birdhouse-ncml'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are already breaking back-compat, should we take the opportunity to fix the default value so they are less weird with respect to their variable name?

THREDDS_DATASET_LOCATION_ON_CONTAINER='/birdhouse-datasets'
THREDDS_SERVICE_DATA_LOCATION_ON_CONTAINER='/birdhouse-service-data'
THREDDS_DATASET_LOCATION_ON_HOST='${BIRDHOUSE_DATA_PERSIST_ROOT}/thredds-datasets'
THREDDS_SERVICE_DATA_LOCATION_ON_HOST='${BIRDHOUSE_DATA_PERSIST_ROOT}/thredds-service-data'

Copy link
Collaborator Author

@mishaschwartz mishaschwartz Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with that. Renaming the THREDDS_DATASET_LOCATION_ON_HOST and THREDDS_SERVICE_DATA_LOCATION_ON_HOST variables aren't really part of this PR since there's no "pavics" in the name but if we're renaming the other two we might as well do them all at once.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps you are right, they do not contain "pavics"! Sorry, I accidentally added 2 more variable changes. I am okay if you decide to not change them.

I think the old default values are also repeated in env.local.example, if my memory is good and you decide to go with this. Do a search for the old default values just to be sure.

if [ -d "${adir}" ]; then
cd "${adir}" || exit

# fail fast if unclean checkout
if [ ! -z "$(git status -u --porcelain)" ]; then
if [ ! -z "$(git status --untracked-files=no --porcelain)" ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be --untracked-files=all because the default was all.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is the old default. But why? I mean, does it break the update if there are untracked files?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not that it would break the autodeploy, it's more about if the checkout is unclean, then someone is experimenting with the machine, let's not break his test environment.

In other works, autodeploy can also be enabled on dev/staging machine and it will automatically keep those machines up-to-date as long as the machine is not being actively used for development purposes. Very convenient when you have a fleet of test machines and you want them to be always up-to-date, ready to be used as test environment, and when they are in used, autodeploy won't touch them.

On a production machine, having untracked files means someone is testing directly in prod !!! It's probably for an emergency, again do not break that. And it gives a very simple and quick way to temporary disable autodeploy: just touch a new file like disable-autodeploy-because-of -XYZ-reason.txt.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to revert this because making this change here was the wrong place to do it.

On a production machine, having untracked files means someone is testing directly in prod

There are many other reasons why you might have untracked files in prod:

  • multiple env.local files
  • custom components
  • notes and readme files

By restricting what can go in this folder we limit lots of useful use cases. This is one of the reasons that I don't use the auto deploy components in production (the other being that I want to be able to understand updates before I deploy them in production).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many other reasons why you might have untracked files in prod:

* multiple env.local files

We have this in our private repo.

* custom components

We have many external components in their own repo, most are private except this one https://github.com/bird-house/birdhouse-deploy-ouranos/

* notes and readme files

Don't have this one but I don't see why they can not be committed to one of the repos instead of being uncommitted and risking to lose it or unable to track their changes.

We can have meeting so I can show you our setup, with autodeploy on all our staging hosts as well.

@@ -0,0 +1 @@
CREATE DATABASE ${BIRDHOUSE_GENERIC_BIRD_POSTGRES_DB};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing .gitignore update matching the generated file of this new template file?


# Set backwards compatible allowed to False explicitly since the current default
# is True when not executing through the CLI.
# tmut may add a bunch of messages to stderr if this is not set. This may cause confusion when trying to debug a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tput and not tmut?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do a search, I vaguely seen more tmut I think.

@fmigneault
Copy link
Collaborator

@tlvu
Beside the mandatory vars section, only the following are configured.

export SERVER_NAME=CRIM-TEST-CI
export SERVER_INSTITUTION=CRIM
export SERVER_SUBJECT=Testing
export SERVER_TAGS=test,ci,validation,integration,end-2-end
export SERVER_DESCRIPTION="
Platform to test functionatities of birdhouse-deploy (https://github.com/bird-house/birdhouse-deploy)
employed by multiple institutions to provide the core configuration of components for PAVICS/DACCS/Marble nodes
(https://github.com/DACCS-Climate/Marble-node-registry).
"
export [email protected]

export EXTRA_CONF_DIRS="
    ./config/proxy
    ./config/magpie
    ./config/twitcher
    ./config/canarie-api
    ./config/geoserver
    ./config/finch
    ./config/raven
    ./config/hummingbird
    ./config/thredds
    ./config/portainer
    ./config/jupyterhub
    ./components/proxy
    ./components/magpie
    ./components/twitcher
    ./components/canarie-api
    ./components/geoserver
    ./components/finch
    ./components/raven
    ./components/hummingbird
    ./components/thredds
    ./components/portainer
    ./components/jupyterhub
    ./components/monitoring
    ./components/weaver
    ./components/cowbird
    ./components/stac
    ./optional-components/canarie-api-full-monitoring
    ./optional-components/all-public-access
    ./optional-components/testthredds
    ./optional-components/secure-thredds
    ./optional-components/secure-data-proxy
    ./optional-components/stac-data-proxy
    ./optional-components/stac-populator
    ./optional-components/wps-healthchecks
    ./optional-components/database-external-ports
    ./optional-components/test-weaver
    ./optional-components/test-cowbird-jupyter-access
    ./optional-components/test-geoserver-secured-access
    ./optional-components/x-robots-tag-header
"
# must toggle the option to have pavics-sdi optional weaver component tested:
# https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/blob/master/Jenkinsfile
export TEST_PAVICS_SDI_WEAVER=true
# in turn, the following variable must also be set to force to have pavics-sdi optional component notebook added:
# https://github.com/Ouranosinc/pavics-sdi/blob/master/docs/source/notebook-components/weaver_example.ipynb
# but since it is executed via 'PAVICS-e2e-workflow-tests', it must be passed indirectly with the extra variable
export EXTRA_TEST_ENV_VAR="${EXTRA_TEST_ENV_VAR} WEAVER_TEST_ENABLED=true"

# Docker images name to be used in the jupyterhub
# For PAVICS image, use default from birdhouse-deploy to obtain latest reference automatically.
DOCKER_NOTEBOOK_IMAGES_DEFAULT="${DOCKER_NOTEBOOK_IMAGES}"
if [ "$(echo "${DOCKER_NOTEBOOK_IMAGES}" | grep -c 'pavics/workflow-tests' || true)" -eq 0 ]; then
  echo "WARNING: Fixing missing default 'DOCKER_NOTEBOOK_IMAGES'..."
  #  backward compat
  COMPOSE_DIR="${COMPOSE_DIR:-$(dirname "$(realpath $0)")}"
  # in case of execution by jenkins worker or ubuntu service, consider sourced/exec method can cause $0 to be the runner
  # patch the path manually if invalid
  if [ "$(basename "${COMPOSE_DIR}")" != "birdhouse" ]; then
    echo "WARNING: Detected invalid 'COMPOSE_DIR=${COMPOSE_DIR}'. Overriding."
    COMPOSE_DIR="/home/ubuntu/${GH_REPO:-birdhouse-deploy}/birdhouse"
  fi
  echo "WARNING: Resolved 'COMPOSE_DIR=${COMPOSE_DIR}'"
  if [ -f "${COMPOSE_DIR}/config/jupyterhub/default.env" ]; then
    DOCKER_NOTEBOOK_IMAGES_DEFAULT=$(cat "${COMPOSE_DIR}/config/jupyterhub/default.env" | grep 'DOCKER_NOTEBOOK_IMAGES=' | cut -d '=' -f 2)
  elif [ -f "${COMPOSE_DIR}/components/jupyterhub/default.env" ]; then
    DOCKER_NOTEBOOK_IMAGES_DEFAULT=$(cat "${COMPOSE_DIR}/components/jupyterhub/default.env" | grep 'DOCKER_NOTEBOOK_IMAGES=' | cut -d '=' -f 2)
  fi
  echo "WARNING: Resolved 'DOCKER_NOTEBOOK_IMAGES_DEFAULT=${DOCKER_NOTEBOOK_IMAGES_DEFAULT}'"
fi
export PAVICS_IMAGE="$(echo ${DOCKER_NOTEBOOK_IMAGES_DEFAULT} | grep pavics/workflow-tests | xargs)"
export PAVICS_VERSION="$(echo ${PAVICS_IMAGE} | cut -d ':' -f2)"
export PAVICS_NAME="$(echo ${PAVICS_IMAGE} | cut -d ':' -f1 | sed 's/[^[:alnum:]-]/-/g')"

# Jupyter single-user server images
export DOCKER_NOTEBOOK_IMAGES="${PAVICS_IMAGE}"

export JUPYTERHUB_IMAGE_SELECTION_NAMES="${PAVICS_NAME}${PAVICS_IMAGE:+:}${PAVICS_VERSION}"

echo "INFO: Resolved 'DOCKER_NOTEBOOK_IMAGES=${DOCKER_NOTEBOOK_IMAGES}'"
echo "INFO: Resolved 'JUPYTERHUB_IMAGE_SELECTION_NAMES=${JUPYTERHUB_IMAGE_SELECTION_NAMES}'"

# allow jupyterhub user selection of which notebook image to run
# see https://jupyter-docker-stacks.readthedocs.io/en/latest/using/selecting.html
export ENABLE_JUPYTERHUB_MULTI_NOTEBOOKS="
c.DockerSpawner.image_whitelist = {
  **{
    _name: _img for _name, _img in
    zip(os.environ['JUPYTERHUB_IMAGE_SELECTION_NAMES'].split(), os.environ['DOCKER_NOTEBOOK_IMAGES'].split())
  },
  'jupyter/scipy-notebook': 'jupyter/scipy-notebook',
  'jupyter/r-notebook': 'jupyter/r-notebook',
  'jupyter/tensorflow-notebook': 'jupyter/tensorflow-notebook',
  'jupyter/datascience-notebook': 'jupyter/datascience-notebook',
  'jupyter/pyspark-notebook': 'jupyter/pyspark-notebook',
  'jupyter/all-spark-notebook': 'jupyter/all-spark-notebook',
}
"

@fmigneault
Copy link
Collaborator

@mishaschwartz

I'd appreciate your opinion:

I'm tempted to bump this a major version

I think MINOR could be sufficient since it is possible (at least from the CI's perspective) to run the stack without any change and tests working end-to-end, but I'm not against MAJOR either if @tlvu thinks the defaults (which TBD?) cause sufficient changes on his end.

I think the changes to the documentation adds a lot of precision and details, but they are not themselves introducing breaking changes. I don't think they reflect the semver mention "changes that requires significant documentation update" hinting that the documentation updates must be caused by/resulting from the stack changes initially.

I would consider MAJOR necessary if the introduced bin/birdhouse becomes the de facto runner, and that we phase out the use of birdhouse/pavics-compose.sh. However, since the birdhouse/read-configs.include.sh still relies on finding birdhouse-compose.sh, MINOR seems sufficient.

Again, not a strong feeling about either MINOR or MAJOR for this case. Same result from my perspective.

@tlvu

So for vars that we never had to set in env.local because we were relying on the old default values, we now have to set them to get back the default values.

Let me know which vars you refer to (is it only the THREDDS ones mentioned in #428 (comment) ?). I have not applied any change in env.local or the compose script to run this PR. It is the same CI and config that runs on master, other PRs and this one.

@mishaschwartz
Copy link
Collaborator Author

@tlvu

Now the breaking part: some old default values have changed. So even if the old config var name still work, their default value have changed.

In some cases the old default is preserved (see BIRDHOUSE_BACKWARDS_COMPATIBLE_HARDCODED_DEFAULTS in default.env).

So for vars that we never had to set in env.local because we were relying on the old default values, we now have to set them to get back the default values.

Yes, in the migration guide we write:

- The following default values have changed. If your deployment was using the old default value, update your
``env.local`` file to explicitly set the old default values.

could I have the list of vars you had to set to keep the github pipeline and all your existing hosts running?

See the table in the migration guide for a list of variables that need to be changed to keep defaults backwards compatible:

| old variable name | new variable name | old default value | new default value |
|--------------------------------------------|--------------------------------------|-------------------------|:---------------------------|
| POSTGRES_PAVICS_USERNAME | BIRDHOUSE_POSTGRES_USERNAME | postgres-pavics | postgres-birdhouse |
| THREDDS_DATASET_LOCATION_ON_CONTAINER | (no change) | /pavics-ncml | /birdhouse-ncml |
| THREDDS_SERVICE_DATA_LOCATION_ON_CONTAINER | (no change) | /pavics-data | /birdhouse-data |
| (hardcoded) | BIRDHOUSE_POSTGRES_DB | pavics | birdhouse |
| PAVICS_LOG_DIR | BIRDHOUSE_LOG_DIR | /var/log/PAVICS | /var/log/birdhouse |
| (hardcoded) | GRAFANA_DEFAULT_PROVIDER_FOLDER | Local-PAVICS | Local-Birdhouse |
| (hardcoded) | GRAFANA_DEFAULT_PROVIDER_FOLDER_UUID | local-pavics | local-birdhouse |
| (hardcoded) | GRAFANA_PROMETHEUS_DATASOURCE_UUID | local_pavics_prometheus | local_birdhouse_prometheus |

If you want to update all variables so that you don't have to run in backwards compatible mode, check out the migration guide for details on what to change.

@mishaschwartz
Copy link
Collaborator Author

@fmigneault

I'm happy to go with a minor bump as well.

I would consider MAJOR necessary if the introduced bin/birdhouse becomes the de facto runner, and that we phase out the use of birdhouse/pavics-compose.sh. However, since the birdhouse/read-configs.include.sh still relies on finding birdhouse-compose.sh, MINOR seems sufficient.

The goal of creating bin/birdhouse was that it would eventually become the de facto runner/interface for everything so that we could phase out or change any internal scripts without breaking backwards compatibility in the future. I'm introducing it here and presenting it as the proper interface to use for any external scripts in the future. Then we can give people lots of time to change their scripts to use bin/birdhouse before we remove pavics-compose.sh in a later version (with a major bump).
For now, we need to keep pavics-compose.sh in order to maintain backwards compatiblity.

@mishaschwartz
Copy link
Collaborator Author

@tlvu @fmigneault given the slight changes I've made based on @tlvu's review I'll give this another 24 hours or so before I pull this in.

@tlvu
Copy link
Collaborator

tlvu commented Jun 3, 2024

Again, not a strong feeling about either MINOR or MAJOR for this case. Same result from my perspective.

Same here. I'll let @mishaschwartz decide on Minor or Major bump. On my side, I'll prepare my production env.local in advance so the upgrade is completely seemless.

So for vars that we never had to set in env.local because we were relying on the old default values, we now have to set them to get back the default values.

Let me know which vars you refer to (is it only the THREDDS ones mentioned in #428 (comment) ?). I have not applied any change in env.local or the compose script to run this PR. It is the same CI and config that runs on master, other PRs and this one.

Oh that probably because the CI pipeline is only testing a fresh deployment case.

For existing production deployments we won't be so lucky. I believe outarde is considered as your production hosts? You will at least have to care for that one.

This is a reminder that the CI pipeline is not enough catch all errors in a PR because it does not test the upgrade scenario. Furthermore the upgrade scenario is actually the most critical path because all existing production deployments will take the upgrade scenario path and not the fresh deployment from scratch path. This is why we currently have the issue that Cowbird do not play nice with existing Magpie users because the upgrade path has never been considered during Cowbird development and testing.

I think all the vars described here by @mishaschwartz will have to be set

| old variable name | new variable name | old default value | new default value |
|--------------------------------------------|--------------------------------------|-------------------------|:---------------------------|
| POSTGRES_PAVICS_USERNAME | BIRDHOUSE_POSTGRES_USERNAME | postgres-pavics | postgres-birdhouse |
| THREDDS_DATASET_LOCATION_ON_CONTAINER | (no change) | /pavics-ncml | /birdhouse-ncml |
| THREDDS_SERVICE_DATA_LOCATION_ON_CONTAINER | (no change) | /pavics-data | /birdhouse-data |
| (hardcoded) | BIRDHOUSE_POSTGRES_DB | pavics | birdhouse |
| PAVICS_LOG_DIR | BIRDHOUSE_LOG_DIR | /var/log/PAVICS | /var/log/birdhouse |
| (hardcoded) | GRAFANA_DEFAULT_PROVIDER_FOLDER | Local-PAVICS | Local-Birdhouse |
| (hardcoded) | GRAFANA_DEFAULT_PROVIDER_FOLDER_UUID | local-pavics | local-birdhouse |
| (hardcoded) | GRAFANA_PROMETHEUS_DATASOURCE_UUID | local_pavics_prometheus | local_birdhouse_prometheus |
. Hopefully all the additional components from external repos that we have on ourside do not require more !

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2675/
ResultFAILURE

BIRDHOUSE_DEPLOY_BRANCH : pavics-to-birdhouse
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-118.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1619/

NOTEBOOK TEST RESULTS
    
[2024-06-03T15:51:15.771Z] ============================= test session starts ==============================
[2024-06-03T15:51:15.771Z] platform linux -- Python 3.11.6, pytest-8.2.0, pluggy-1.5.0
[2024-06-03T15:51:15.771Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2024-06-03T15:51:15.771Z] plugins: anyio-4.3.0, dash-2.17.0, nbval-0.11.0, tornasync-0.6.0.post2, xdist-3.5.0
[2024-06-03T15:51:15.771Z] collected 276 items
[2024-06-03T15:51:15.771Z] 
[2024-06-03T15:51:26.600Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-06-03T15:51:47.061Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-06-03T15:51:50.243Z] notebooks-auth/test_thredds.ipynb ......FFFF.                            [ 14%]
[2024-06-03T15:52:36.547Z] pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb ......          [ 16%]
[2024-06-03T15:52:45.147Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 18%]
[2024-06-03T15:52:53.810Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 21%]
[2024-06-03T15:53:04.548Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 23%]
[2024-06-03T16:00:35.546Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 28%]
[2024-06-03T16:00:37.463Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 28%]
[2024-06-03T16:00:45.498Z] ...............                                                          [ 34%]
[2024-06-03T16:00:53.636Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 35%]
[2024-06-03T16:01:01.071Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 38%]
[2024-06-03T16:01:16.138Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 40%]
[2024-06-03T16:01:21.011Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 42%]
[2024-06-03T16:01:25.448Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .F..F       [ 44%]
[2024-06-03T16:01:53.884Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb .FF..FFFFFFFF.. [ 50%]
[2024-06-03T16:02:38.220Z] F.FFFF.......                                                            [ 54%]
[2024-06-03T16:02:40.397Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb FFFF             [ 56%]
[2024-06-03T16:02:42.375Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 59%]
[2024-06-03T16:03:01.438Z] .................                                                        [ 65%]
[2024-06-03T16:03:08.618Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb F..FF.          [ 67%]
[2024-06-03T16:03:10.012Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 67%]
[2024-06-03T16:03:33.447Z] ........F                                                                [ 71%]
[2024-06-03T16:03:39.217Z] finch-master/docs/source/notebooks/dap_subset.ipynb .FFFFFFFFF.          [ 75%]
[2024-06-03T16:03:45.345Z] finch-master/docs/source/notebooks/finch-usage.ipynb ..FFFF              [ 77%]
[2024-06-03T16:03:46.749Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 77%]
[2024-06-03T16:03:50.318Z] .....                                                                    [ 79%]
[2024-06-03T16:04:08.451Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 79%]
[2024-06-03T16:04:23.844Z] ............                                                             [ 84%]
[2024-06-03T16:04:41.975Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 84%]
[2024-06-03T16:05:01.553Z] .....s.                                                                  [ 86%]
[2024-06-03T16:05:09.690Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 87%]
[2024-06-03T16:05:26.505Z] ..                                                                       [ 88%]
[2024-06-03T16:05:34.667Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 88%]
[2024-06-03T16:06:39.062Z] F........                                                                [ 91%]
[2024-06-03T16:06:49.082Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-6Regridding_Conversion.ipynb . [ 92%]
[2024-06-03T16:11:49.080Z] F...                                                                     [ 93%]
[2024-06-03T16:11:49.080Z] notebooks/hummingbird.ipynb .........F..                                 [ 97%]
[2024-06-03T16:14:27.873Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-06-03T16:14:27.873Z] 
[2024-06-03T16:14:27.873Z] =================================== FAILURES ===================================
    
  

@mishaschwartz
Copy link
Collaborator Author

I'm reverting the changes to the thredds variables because they break the tests and I don't want to go through the effort of fixing the tests again. If we want to change these we can do it in a future update.

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2676/
ResultFAILURE

BIRDHOUSE_DEPLOY_BRANCH : pavics-to-birdhouse
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-118.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1620/

NOTEBOOK TEST RESULTS
    
[2024-06-03T17:31:43.349Z] ============================= test session starts ==============================
[2024-06-03T17:31:43.349Z] platform linux -- Python 3.11.6, pytest-8.2.0, pluggy-1.5.0
[2024-06-03T17:31:43.349Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2024-06-03T17:31:43.349Z] plugins: anyio-4.3.0, dash-2.17.0, nbval-0.11.0, tornasync-0.6.0.post2, xdist-3.5.0
[2024-06-03T17:31:43.349Z] collected 276 items
[2024-06-03T17:31:43.349Z] 
[2024-06-03T17:31:54.855Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-06-03T17:32:15.750Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-06-03T17:32:21.706Z] notebooks-auth/test_thredds.ipynb ...........                            [ 14%]
[2024-06-03T17:33:08.522Z] pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb ......          [ 16%]
[2024-06-03T17:33:17.855Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 18%]
[2024-06-03T17:33:26.278Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 21%]
[2024-06-03T17:33:43.530Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 23%]
[2024-06-03T17:41:05.940Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 28%]
[2024-06-03T17:41:05.941Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 28%]
[2024-06-03T17:41:09.861Z] ...............                                                          [ 34%]
[2024-06-03T17:41:17.455Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 35%]
[2024-06-03T17:41:24.494Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 38%]
[2024-06-03T17:41:38.353Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 40%]
[2024-06-03T17:42:20.540Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 42%]
[2024-06-03T17:42:23.826Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 44%]
[2024-06-03T17:46:17.742Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 50%]
[2024-06-03T17:47:19.461Z] .............                                                            [ 54%]
[2024-06-03T17:47:22.764Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 56%]
[2024-06-03T17:47:24.688Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 59%]
[2024-06-03T17:47:40.114Z] .................                                                        [ 65%]
[2024-06-03T17:47:46.795Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 67%]
[2024-06-03T17:47:47.739Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 67%]
[2024-06-03T17:49:01.608Z] ......FFF                                                                [ 71%]
[2024-06-03T17:49:12.689Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 75%]
[2024-06-03T17:49:20.980Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 77%]
[2024-06-03T17:49:22.365Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 77%]
[2024-06-03T17:49:25.175Z] .....                                                                    [ 79%]
[2024-06-03T17:49:40.100Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 79%]
[2024-06-03T17:49:55.575Z] ............                                                             [ 84%]
[2024-06-03T17:50:22.167Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 84%]
[2024-06-03T17:50:42.532Z] .....s.                                                                  [ 86%]
[2024-06-03T17:50:49.121Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 87%]
[2024-06-03T17:51:05.941Z] ..                                                                       [ 88%]
[2024-06-03T17:51:12.534Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 88%]
[2024-06-03T17:52:09.190Z] F........                                                                [ 91%]
[2024-06-03T17:52:17.326Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-6Regridding_Conversion.ipynb . [ 92%]
[2024-06-03T17:57:09.344Z] F...                                                                     [ 93%]
[2024-06-03T17:57:09.344Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2024-06-03T17:59:32.564Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-06-03T17:59:32.564Z] 
[2024-06-03T17:59:32.564Z] =================================== FAILURES ===================================
    
  

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2678/
ResultFAILURE

BIRDHOUSE_DEPLOY_BRANCH : pavics-to-birdhouse
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-118.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1622/

NOTEBOOK TEST RESULTS
    
[2024-06-04T15:21:49.722Z] ============================= test session starts ==============================
[2024-06-04T15:21:49.722Z] platform linux -- Python 3.11.6, pytest-8.2.0, pluggy-1.5.0
[2024-06-04T15:21:49.722Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2024-06-04T15:21:49.722Z] plugins: anyio-4.3.0, dash-2.17.0, nbval-0.11.0, tornasync-0.6.0.post2, xdist-3.5.0
[2024-06-04T15:21:49.722Z] collected 276 items
[2024-06-04T15:21:49.722Z] 
[2024-06-04T15:21:59.637Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-06-04T15:22:23.212Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-06-04T15:22:30.542Z] notebooks-auth/test_thredds.ipynb ...........                            [ 14%]
[2024-06-04T15:23:16.029Z] pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb ......          [ 16%]
[2024-06-04T15:23:25.074Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 18%]
[2024-06-04T15:23:34.807Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 21%]
[2024-06-04T15:23:43.804Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 23%]
[2024-06-04T15:31:11.084Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 28%]
[2024-06-04T15:31:11.084Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 28%]
[2024-06-04T15:31:12.985Z] ...............                                                          [ 34%]
[2024-06-04T15:31:20.926Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 35%]
[2024-06-04T15:31:29.195Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 38%]
[2024-06-04T15:31:42.461Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 40%]
[2024-06-04T15:31:47.691Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 42%]
[2024-06-04T15:31:52.345Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 44%]
[2024-06-04T15:35:59.765Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 50%]
[2024-06-04T15:37:02.353Z] .............                                                            [ 54%]
[2024-06-04T15:37:06.435Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 56%]
[2024-06-04T15:38:14.157Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb EEEEEEEE [ 59%]
[2024-06-04T15:38:27.807Z] EEEEEEEEEEEEEEEEE                                                        [ 65%]
[2024-06-04T15:38:36.739Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 67%]
[2024-06-04T15:38:37.690Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 67%]
[2024-06-04T15:38:55.496Z] .........                                                                [ 71%]
[2024-06-04T15:39:04.499Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 75%]
[2024-06-04T15:39:13.153Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 77%]
[2024-06-04T15:39:14.102Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 77%]
[2024-06-04T15:39:17.443Z] .....                                                                    [ 79%]
[2024-06-04T15:39:32.352Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 79%]
[2024-06-04T15:39:47.964Z] ............                                                             [ 84%]
[2024-06-04T15:40:02.864Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 84%]
[2024-06-04T15:40:40.001Z] .....s.                                                                  [ 86%]
[2024-06-04T15:40:46.588Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 87%]
[2024-06-04T15:41:04.057Z] ..                                                                       [ 88%]
[2024-06-04T15:41:12.213Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 88%]
[2024-06-04T15:42:14.646Z] F........                                                                [ 91%]
[2024-06-04T15:42:24.642Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-6Regridding_Conversion.ipynb . [ 92%]
[2024-06-04T15:47:15.298Z] F...                                                                     [ 93%]
[2024-06-04T15:47:15.298Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2024-06-04T15:49:38.536Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-06-04T15:49:38.536Z] 
[2024-06-04T15:49:38.536Z] ==================================== ERRORS ====================================
    
  

@mishaschwartz
Copy link
Collaborator Author

aaand test are failing again. Nothing in the code has changed with this PR so I'm going to just assume that the flaky tests got more flaky and I'm going to pull this in.

@tlvu
Copy link
Collaborator

tlvu commented Jun 4, 2024

Before pulling this in, can you revert to the existing behavior of git status --untracked-files=all, see this comment thread #428 (comment)

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2680/
ResultFAILURE

BIRDHOUSE_DEPLOY_BRANCH : pavics-to-birdhouse
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-216.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1623/

NOTEBOOK TEST RESULTS
    
[2024-06-04T17:57:08.663Z] ============================= test session starts ==============================
[2024-06-04T17:57:08.663Z] platform linux -- Python 3.11.6, pytest-8.2.0, pluggy-1.5.0
[2024-06-04T17:57:08.663Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master
[2024-06-04T17:57:08.663Z] plugins: anyio-4.3.0, dash-2.17.0, nbval-0.11.0, tornasync-0.6.0.post2, xdist-3.5.0
[2024-06-04T17:57:08.663Z] collected 276 items
[2024-06-04T17:57:08.663Z] 
[2024-06-04T17:57:18.123Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-06-04T17:57:40.320Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-06-04T17:57:47.083Z] notebooks-auth/test_thredds.ipynb ...........                            [ 14%]
[2024-06-04T17:58:35.342Z] pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb ......          [ 16%]
[2024-06-04T17:58:52.502Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 18%]
[2024-06-04T17:59:01.922Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 21%]
[2024-06-04T17:59:18.523Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 23%]
[2024-06-04T18:12:41.804Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 28%]
[2024-06-04T18:12:44.353Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 28%]
[2024-06-04T18:12:55.530Z] ...............                                                          [ 34%]
[2024-06-04T18:13:03.865Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 35%]
[2024-06-04T18:13:10.690Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 38%]
[2024-06-04T18:13:26.285Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 40%]
[2024-06-04T18:13:32.294Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 42%]
[2024-06-04T18:13:37.234Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 44%]
[2024-06-04T18:17:46.538Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 50%]
[2024-06-04T18:18:49.658Z] .............                                                            [ 54%]
[2024-06-04T18:18:52.670Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 56%]
[2024-06-04T18:18:54.449Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 59%]
[2024-06-04T18:19:10.503Z] .................                                                        [ 65%]
[2024-06-04T18:19:18.351Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 67%]
[2024-06-04T18:19:19.297Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 67%]
[2024-06-04T18:19:36.831Z] .........                                                                [ 71%]
[2024-06-04T18:19:45.367Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 75%]
[2024-06-04T18:19:54.684Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 77%]
[2024-06-04T18:19:57.219Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 77%]
[2024-06-04T18:20:00.063Z] .....                                                                    [ 79%]
[2024-06-04T18:20:22.022Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 79%]
[2024-06-04T18:20:41.668Z] ............                                                             [ 84%]
[2024-06-04T18:20:59.756Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 84%]
[2024-06-04T18:21:27.427Z] .....s.                                                                  [ 86%]
[2024-06-04T18:21:34.006Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 87%]
[2024-06-04T18:21:51.519Z] ..                                                                       [ 88%]
[2024-06-04T18:21:59.650Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 88%]
[2024-06-04T18:23:01.251Z] F........                                                                [ 91%]
[2024-06-04T18:23:11.237Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-6Regridding_Conversion.ipynb . [ 92%]
[2024-06-04T18:30:26.294Z] F...                                                                     [ 93%]
[2024-06-04T18:30:26.294Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2024-06-04T18:32:59.023Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-06-04T18:32:59.023Z] 
[2024-06-04T18:32:59.023Z] =================================== FAILURES ===================================
    
  

@crim-jenkins-bot
Copy link
Collaborator

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2679/
ResultFAILURE

BIRDHOUSE_DEPLOY_BRANCH : pavics-to-birdhouse
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-118.rdext.crim.ca

PAVICS-e2e-workflow-tests Pipeline Results

Tests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1624/

NOTEBOOK TEST RESULTS
    
[2024-06-04T17:57:39.710Z] ============================= test session starts ==============================
[2024-06-04T17:57:39.710Z] platform linux -- Python 3.11.6, pytest-8.2.0, pluggy-1.5.0
[2024-06-04T17:57:39.710Z] rootdir: /home/jenkins/agent/workspace/PAVICS-e2e-workflow-tests_master@2
[2024-06-04T17:57:39.710Z] plugins: anyio-4.3.0, dash-2.17.0, nbval-0.11.0, tornasync-0.6.0.post2, xdist-3.5.0
[2024-06-04T17:57:39.710Z] collected 276 items
[2024-06-04T17:57:39.710Z] 
[2024-06-04T17:57:49.985Z] notebooks-auth/geoserver.ipynb ..................                        [  6%]
[2024-06-04T17:58:10.890Z] notebooks-auth/test_cowbird_jupyter.ipynb ..........                     [ 10%]
[2024-06-04T17:58:18.091Z] notebooks-auth/test_thredds.ipynb ...........                            [ 14%]
[2024-06-04T17:59:06.375Z] pavics-sdi-master/docs/source/notebooks/CaSR_basic.ipynb ......          [ 16%]
[2024-06-04T17:59:14.684Z] pavics-sdi-master/docs/source/notebooks/WCS_example.ipynb .......        [ 18%]
[2024-06-04T17:59:22.718Z] pavics-sdi-master/docs/source/notebooks/WFS_example.ipynb ......         [ 21%]
[2024-06-04T17:59:28.679Z] pavics-sdi-master/docs/source/notebooks/WMS_example.ipynb ........       [ 23%]
[2024-06-04T18:12:43.958Z] pavics-sdi-master/docs/source/notebooks/climex.ipynb ............        [ 28%]
[2024-06-04T18:12:45.345Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-climate-stations.ipynb . [ 28%]
[2024-06-04T18:12:55.459Z] ...............                                                          [ 34%]
[2024-06-04T18:13:03.564Z] pavics-sdi-master/docs/source/notebooks/eccc-geoapi-xclim.ipynb .....    [ 35%]
[2024-06-04T18:13:10.901Z] pavics-sdi-master/docs/source/notebooks/esgf-dap.ipynb ......            [ 38%]
[2024-06-04T18:13:26.015Z] pavics-sdi-master/docs/source/notebooks/forecasts.ipynb ......           [ 40%]
[2024-06-04T18:13:32.798Z] pavics-sdi-master/docs/source/notebooks/opendap.ipynb .......            [ 42%]
[2024-06-04T18:13:37.323Z] pavics-sdi-master/docs/source/notebooks/pavics_thredds.ipynb .....       [ 44%]
[2024-06-04T18:17:39.437Z] pavics-sdi-master/docs/source/notebooks/regridding.ipynb ............... [ 50%]
[2024-06-04T18:18:52.120Z] .............                                                            [ 54%]
[2024-06-04T18:18:55.603Z] pavics-sdi-master/docs/source/notebooks/rendering.ipynb ....             [ 56%]
[2024-06-04T18:18:57.562Z] pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb ........ [ 59%]
[2024-06-04T18:19:13.559Z] .................                                                        [ 65%]
[2024-06-04T18:19:21.256Z] pavics-sdi-master/docs/source/notebooks/subsetting.ipynb ......          [ 67%]
[2024-06-04T18:19:22.199Z] pavics-sdi-master/docs/source/notebook-components/weaver_example.ipynb . [ 67%]
[2024-06-04T18:19:41.115Z] .........                                                                [ 71%]
[2024-06-04T18:19:50.419Z] finch-master/docs/source/notebooks/dap_subset.ipynb ...........          [ 75%]
[2024-06-04T18:19:59.737Z] finch-master/docs/source/notebooks/finch-usage.ipynb ......              [ 77%]
[2024-06-04T18:20:00.677Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-1DataAccess.ipynb . [ 77%]
[2024-06-04T18:20:04.000Z] .....                                                                    [ 79%]
[2024-06-04T18:20:25.957Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-2Subsetting.ipynb . [ 79%]
[2024-06-04T18:20:45.920Z] ............                                                             [ 84%]
[2024-06-04T18:21:00.849Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-3Climate-Indicators.ipynb . [ 84%]
[2024-06-04T18:21:30.779Z] .....s.                                                                  [ 86%]
[2024-06-04T18:21:37.359Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-4Ensembles.ipynb . [ 87%]
[2024-06-04T18:21:55.573Z] ..                                                                       [ 88%]
[2024-06-04T18:22:02.152Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-5Visualization.ipynb . [ 88%]
[2024-06-04T18:23:08.572Z] F........                                                                [ 91%]
[2024-06-04T18:23:18.556Z] PAVICS-landing-master/content/notebooks/climate_indicators/PAVICStutorial_ClimateDataAnalysis-6Regridding_Conversion.ipynb . [ 92%]
[2024-06-04T18:31:33.544Z] F...                                                                     [ 93%]
[2024-06-04T18:31:33.544Z] notebooks/hummingbird.ipynb ............                                 [ 97%]
[2024-06-04T18:34:06.328Z] notebooks/stress-tests.ipynb ......                                      [100%]
[2024-06-04T18:34:06.328Z] 
[2024-06-04T18:34:06.328Z] =================================== FAILURES ===================================
    
  

@mishaschwartz mishaschwartz merged commit b229634 into master Jun 4, 2024
4 of 5 checks passed
@mishaschwartz mishaschwartz deleted the pavics-to-birdhouse branch June 4, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/deployment Related to deployment utilities and scripts ci/operations Continuous Integration components ci/tests Issues or changes related to tests scripts component/cowbird Related to https://github.com/Ouranosinc/cowbird component/geoserver Related to GeoServer or one of its underlying services component/jupyterhub Related to JupyterHub as development frontend with notebooks component/magpie Related to https://github.com/Ouranosinc/Magpie component/STAC Features or components related to STAC component/THREDDS Features or components related to THREDDS component/twitcher Related to https://github.com/bird-house/twitcher component/weaver Related to https://github.com/crim-ca/weaver documentation Improvements or additions to documentation feature/node-registry Related to https://github.com/DACCS-Climate/DACCS-node-registry feature/WPS Feature or service related to Web Processing Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

❓ [Question]: Can we change PAVICS to Birdhouse everywhere
4 participants