Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canarie-api: fix new Thredds v5 monitoring URL #485

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

tlvu
Copy link
Collaborator

@tlvu tlvu commented Dec 6, 2024

Overview

Fix the error below at the URL https://HOST/canarie/node/service/stats: Bad return code from http://thredds:8080//twitcher/ows/proxy/thredds/catalog.html (Expecting 200, Got 404

Old URL: http://thredds:8080//twitcher/ows/proxy/thredds/catalog.html
New URL: http://thredds:8080/twitcher/ows/proxy/thredds/catalog/catalog.html

An oversight from the previous PR #413

Changes

Non-breaking changes

  • Adapt canarie-api to new Thredds v5 URL

CI Operations

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false

Fix the error below at the URL https://HOST/canarie/node/service/stats:
Bad return code from http://thredds:8080//twitcher/ows/proxy/thredds/catalog.html (Expecting 200, Got 404

Old URL: http://thredds:8080//twitcher/ows/proxy/thredds/catalog.html
New URL: http://thredds:8080/twitcher/ows/proxy/thredds/catalog/catalog.html
@github-actions github-actions bot added the component/THREDDS Features or components related to THREDDS label Dec 6, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 6, 2024
Copy link
Collaborator

@mishaschwartz mishaschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait on this until my concerns in #413 (comment) are addressed.

@tlvu
Copy link
Collaborator Author

tlvu commented Dec 9, 2024

@mishaschwartz Is it okay to merge this one too? Since we are keeping Thredds v5.

@tlvu tlvu requested a review from mishaschwartz December 9, 2024 17:24
@mishaschwartz
Copy link
Collaborator

sure

@github-actions github-actions bot added the ci/operations Continuous Integration components label Dec 9, 2024
@tlvu tlvu merged commit bc2307e into master Dec 9, 2024
3 of 5 checks passed
@tlvu tlvu deleted the update-thredds-canarieapi-monitoring-url branch December 9, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/operations Continuous Integration components component/THREDDS Features or components related to THREDDS documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants