-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JupyterHub: update jupyterhub
component default version to 5.2.1
#493
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog should describe that changing to this version can break everything depending on the OS the server is running on, since the whole Jenkins CI fiasco originates from this.
Link to Ouranosinc/PAVICS-e2e-workflow-tests#137
It is not necessarily a seamless change.
c.Authenticator.blacklist = blocked_users # v0.9+ | ||
c.Authenticator.blocked_users = blocked_users # v1.2+ | ||
|
||
c.Authenticator.allow_all = True # v5.0+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This combination is extremely confusing and prone to misinterpretation.
Please provide the doc reference and some comment.
Even after reading the doc details, it feels config to "allow all" after an explicit set of blocked users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to maintain the previous behaviour which is what is mentioned a few times both in the link you provided and the upgrade guide (https://jupyterhub.readthedocs.io/en/latest/howto/upgrading-v5.html#authenticator-allow-all-and-allow-existing-users).
We use Magpie as the source of truth for who our users are so we do not want jupyterhub to filter/block those users further.
Can you clarify what the confusion is please? That would help me draft a better comment to help.
``` | ||
birdhouse compose exec jupyterhub jupyterhub upgrade-db | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't this be defined as a compose service jupyterhub-db-migration
with restart: "no"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can. But I don't think it should. We do not want this to run every time jupyterhub starts up. This database upgrade is described as "not too disruptive" but more involved upgrades in the future may break things. This is really something that we want to do manually.
jupyterhub
component default version to [5.2.1](https://github.com/Ouranosinc/jupyterhub/releases/tag/5.2.1-20241114)jupyterhub
component default version to 5.2.1
Overview
This implements all changes between JupyterHub version
4.1.6 and 5.2.1.
This update requires the following manual upgrade steps:
c.DockerSpawner.image_whitelist
config option in theJUPYTERHUB_ENABLE_MULTI_NOTEBOOKS
environnment variable. Changec.DockerSpawner.image_whitelist
to
c.DockerSpawner.allowed_images
.jupyterhub_data_persistence
volume if you're not storing any custominformation there and if you haven't manually set
c.Authenticator.allow_all
toFalse
(ensure thatthe stack is stopped and all jupyterlab containers have been stopped and removed first).
If you have changed any of the default
jupyterhub
settings you may need to consult the JupyterHub upgrade guide to see if any of those settings have been changed.Changes
Non-breaking changes
Breaking changes
Related Issue / Discussion
Additional Information
CI Operations
birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false