Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport from Flyingpigeon and Emu #89

Merged
merged 10 commits into from
Jun 5, 2020
Merged

Conversation

tlvu
Copy link

@tlvu tlvu commented May 28, 2020

Backport a few differences when synching with Flyingpigeon and Emu.

Some noticeable changes:

  • Fixed wrong OUTPUT_URL in target refresh-notebooks.
  • Fixed wrong http port in Travis-CI breaking make test-notebooks.
  • Added make docs in Travis-CI.

Matching FlyingPigeon PR bird-house/flyingpigeon#330 and Emu PR bird-house/emu#103

Copy link
Member

@cehbrecht cehbrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments ... output_url.

{{cookiecutter.project_repo_name}}/Makefile Show resolved Hide resolved
@tlvu tlvu changed the title Backport from Flyingpigeon Backport from Flyingpigeon and Emu Jun 2, 2020
@tlvu tlvu requested a review from cehbrecht June 2, 2020 16:49
@cehbrecht
Copy link
Member

@tlvu feel free to merge.

tlvu added a commit to bird-house/emu that referenced this pull request Jun 5, 2020
…ookiecutter

Setup cruft to refresh from cookiecutter.

This PR is part of issue bird-house/cookiecutter-birdhouse#61, rolling out cruft as a mechanism to easily update cookiecutter template changes to existing project.

Require cookiecutter-birdhouse PR bird-house/cookiecutter-birdhouse#89

Noticeable changes:

* Docs testing also enabled in Travis-CI
* Use `make develop` in Travis-CI instead of manual install
* ReadTheDocs build changed to use minimal `environment-docs.yml` and mock import

Travis-CI build working: https://travis-ci.org/github/bird-house/emu/builds/694623148
RtD build working: https://readthedocs.org/projects/emu/builds/11184100/
tlvu added a commit to bird-house/flyingpigeon that referenced this pull request Jun 5, 2020
…refresh

Setup cruft for cookiecutter refresh.

This PR is part of issue bird-house/cookiecutter-birdhouse#61, rolling out cruft as a mechanism to easily update cookiecutter template changes to existing project.

Require cookiecutter-birdhouse PR bird-house/cookiecutter-birdhouse#89

In `.cruft.json`, I set `"project_short_description": "A Web Processing Service Testbed."` from the `README.rst`, let me know if that is still correct.

In `README.rst`, I took the Flyingpigeon bird description from `docs/source/index.rst`.

Noticeable changes:

* Notebooks testing enabled in Travis-CI but allowed to fail, waiting for this issue #328 according to @nilshempelmann 
* Fix pymetalink install to be able to run notebook tests
* Docs testing also enabled in Travis-CI

Travis-CI build working: https://travis-ci.org/github/bird-house/flyingpigeon/builds/694013491
RtD build working: https://readthedocs.org/projects/flyingpigeon/builds/11184473/
@tlvu tlvu merged commit 90bbb15 into master Jun 5, 2020
@tlvu tlvu deleted the backport-from-flyingpigeon branch June 5, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants