support birdhouse-deploy>=2.4.0 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlvu
approved these changes
Jun 4, 2024
fmigneault
approved these changes
Jun 5, 2024
|
Can someone advise what the release procedure is for this repo? |
|
Add details in the CHANGES (I see that https://github.com/bird-house/pavics-jupyter-base/tree/0.5.0 exists, but the section is not updated, so need to adjust this). Once merged, DockerHub should auto-build the latest with I see that https://github.com/bird-house/pavics-jupyter-base/tree/support-birdhouse-deploy-2.4.0 build fails: https://hub.docker.com/repository/registry-1.docker.io/birdhouse/pavics-jupyter-base/builds/e9ffc5ec-9b3e-4ca0-b5b0-68875900e0c4 Need to address this before merging/tag/release. |
fmigneault
requested changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
scheduler-jobs/deploy_data_pavics_jupyter.envscript to allow it to discover the log directory using theBIRDHOUSE_LOG_DIRor thePAVICS_LOG_DIRenvironment variable.This is in order to support the variable name changes introduced in birdhouse-deploy versions >= 2.4.0.