Rename "Rocket Chat Admin" role to "Keybase Admin" #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per bisq-network/roles#79 (comment) Note that the ROCKET_CHAT_ADMIN enum label has not been renamed for the backward compatibility reasons discussed in BondedRoleType Javadoc. See also bisq-network/roles#60.
sqrrm
approved these changes
May 5, 2020
|
I think renaming the enum shouldn't be a problem either. @ManfredKarrer this touch DAO code, just a comment, but still. |
I assume as well, but not sure if testing effort is worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per bisq-network/roles#79 (comment)
Note that the ROCKET_CHAT_ADMIN enum label has not been renamed for
the backward compatibility reasons discussed in BondedRoleType Javadoc.
See also bisq-network/roles#60.