-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update security advisories with recently assigned CVE IDs #1086
base: master
Are you sure you want to change the base?
Conversation
@@ -1,5 +1,5 @@ | |||
--- | |||
title: Disclosure of crash using malicious BIP72 URI | |||
title: Disclosure of CVE-2024-52918 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be better to leave the title and just add the CVE number to the end
title: Disclosure of CVE-2024-52918 | |
title: Disclosure of crash using malicious BIP72 URI (CVE-2024-52918) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree but i chose to be consistent with previous advisories. If we want to change the existing format let's do it in another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also prefer if the titles continued to contain the gist of the vulnerability as the CVE ID provides zero context unless you know about the CVE in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also agree that the CVE ID does not provide any context, I believe that titles containing the essence of the vulnerability are more useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach reduces the information content of the titles and I would consider it a disimprovement.
How about replacing the word "Disclosure" with the CVE ID? E.g.
-title: Disclosure of crash using malicious BIP72 URI
+title: CVE-2024-52918: Crash using malicious BIP72 URI
Or what @0xB10C said.
Only the
inv-to-send
advisory doesn't have one because there is a misunderstanding who claims it should beCVE-2023-33297
. I explained it is an ID which was claimed by a troll on behalf of the project and i'm now awaiting their response. I don't think it should be a blocker to publish the other 13 IDs.