Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Block Clock to Block Status #441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnny9
Copy link
Contributor

@johnny9 johnny9 commented Jan 21, 2025

These changes rename all instances of "Block Clock" to "Block Status" under the qml directory.

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build fails
make[1]: *** No rule to make target 'qml/components/blockclockdial.cpp', needed by 'qml/components/qt_libbitcoinqt_a-blockclockdial.o'. Stop.

@MarnixCroes
Copy link
Contributor

Copy link

@ciegovolador ciegovolador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK on removing "Clock".

Just thinking it loud, shouldn't be more like "Sync" status? (moreover to avoid confusion with an individual block status).

Also found this in current QT desktop app source (src/qt/clientmodel.h):

enum class SyncType {
    HEADER_PRESYNC,
    HEADER_SYNC,
    BLOCK_SYNC
};

Maybe we need something like that later to identify on which sync we are...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants