Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(swift): update build-local-swift.sh to use xcodebuild tool #557

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Jun 12, 2024

Description

I updated the build script to use the xcodebuild tool which creates the xc.framework so we don't need to manually copy header and libbdkffi.a files or manually create the Info.plist file.

I don't know if this will fix any current problems, but it's a start to getting things built the Apple™ way.

Notes to the reviewers

For this update I referenced:

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@thunderbiscuit
Copy link
Member

thunderbiscuit commented Jun 12, 2024

Really good to see the build workflow being updated and cleaned up a bit. A few thoughts just so I don't forget:

  • The bdk.xcframework directory can now be completely removed from version control I think
  • Since the PR in chore: update publish-spm.yaml to use xcodebuild tool bdk-swift#49 now uses the script, I think a name change for that script might work well
  • We just need to make sure that this new Info.plist doesn't impact our fix for XCode 15.3

@reez
Copy link
Collaborator

reez commented Jun 12, 2024

  • We just need to make sure that this new Info.plist doesn't impact our fix for XCode 15.3

Just did some testing a few different ways to see if it would break in Xcode 15.3+ and Xcode 16 beta, and everything worked as expected, so that's really great, nice Steve!

@thunderbiscuit
Copy link
Member

Note that this fixes #552.

@notmandatory notmandatory force-pushed the use_xcodebuild branch 2 times, most recently from d46b54a to 21ac526 Compare June 12, 2024 23:02
@thunderbiscuit
Copy link
Member

I have also built this locally and all tests pass. CI looks good. @reez do I understand that you have tried using this in XCode and the example iOS app?

It's an important change because it rewrites how we build and publish our Swift package, but I don't know that we could test it any more than what we did (let me know if you'd like to still test it in different ways). My take on this is that I'd rather merge it before we get to the beta releases and the true 1.0, so we catch anything and fix if needed earlier than later.

It's an important change so I'll wait for ACKs of all 3 of us before merging.

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 21ac526.

@reez
Copy link
Collaborator

reez commented Jun 13, 2024

@reez do I understand that you have tried using this in XCode and the example iOS app?

Correct.

I don't know that we could test it any more than what we did

Agree.

My take on this is that I'd rather merge it before we get to the beta releases and the true 1.0

Agree.

Tested ACK 21ac526.

@notmandatory
Copy link
Member Author

ACK from me, merge it whenever you're ready.

@thunderbiscuit thunderbiscuit merged commit 6642c58 into bitcoindevkit:master Jun 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration pipeline related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants