-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(swift): update build-local-swift.sh to use xcodebuild tool #557
chore(swift): update build-local-swift.sh to use xcodebuild tool #557
Conversation
a546262
to
074c070
Compare
074c070
to
cebd0d4
Compare
Really good to see the build workflow being updated and cleaned up a bit. A few thoughts just so I don't forget:
|
Just did some testing a few different ways to see if it would break in Xcode 15.3+ and Xcode 16 beta, and everything worked as expected, so that's really great, nice Steve! |
Note that this fixes #552. |
d46b54a
to
21ac526
Compare
I have also built this locally and all tests pass. CI looks good. @reez do I understand that you have tried using this in XCode and the example iOS app? It's an important change because it rewrites how we build and publish our Swift package, but I don't know that we could test it any more than what we did (let me know if you'd like to still test it in different ways). My take on this is that I'd rather merge it before we get to the beta releases and the true 1.0, so we catch anything and fix if needed earlier than later. It's an important change so I'll wait for ACKs of all 3 of us before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK 21ac526.
ACK from me, merge it whenever you're ready. |
…to use xcodebuild tool
21ac526
to
6642c58
Compare
Description
I updated the build script to use the xcodebuild tool which creates the xc.framework so we don't need to manually copy header and
libbdkffi.a
files or manually create theInfo.plist
file.I don't know if this will fix any current problems, but it's a start to getting things built the Apple™ way.
Notes to the reviewers
For this update I referenced:
Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing