Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(draft) chore: uniffi 0.28.2 #614

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

reez
Copy link
Collaborator

@reez reez commented Oct 31, 2024

Description

Updating to uniffi https://github.com/mozilla/uniffi-rs/releases/tag/v0.28.2

Notes to the reviewers

We have to update bitcoin-ffi first, so I'm using my fork branch bitcoindevkit/bitcoin-ffi#28 until that gets merged.

Testing out some of https://mozilla.github.io/uniffi-rs/next/swift/uniffi-bindgen-swift.html

Which is only available in 0.28.2 mozilla/uniffi-rs#2248 (comment)

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@thunderbiscuit
Copy link
Member

Love this if it gives you greater control on the resulting library! Does it provide new stuff you'd like to use? Other question: is it only useable if we bump bitcoin-ffi?

@reez
Copy link
Collaborator Author

reez commented Nov 15, 2024

Does it provide new stuff you'd like to use?

In my initial exploration nothing that was immediately needed, so there's no big rush, but more exploration to be done potentially

Other question: is it only useable if we bump bitcoin-ffi?

TBD, likely based on some more findings from #619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants