Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_fee_estimates to EsploraClient #648

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

reez
Copy link
Collaborator

@reez reez commented Jan 10, 2025

Description

Add get_fee_estimates on EsploraClient

Notes to the reviewers

Similar method was added for Electrum in #641 and I believe this is the closest comp for Esplora so I wanted to add it.

Can run test locally similar to what thunder laid out here by import org.bitcoindevkit.EsploraClient then adding something like:

val feeEstimates = client.getFeeEstimates()
println("Fee estimates: $feeEstimates")
Screenshot 2025-01-10 at 9 22 03 AM

Changelog notice

Added:
  - EsploraClient::get_fee_estimates [#648]

[#648]: https://github.com/bitcoindevkit/bdk-ffi/pull/641

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@thunderbiscuit thunderbiscuit self-requested a review January 10, 2025 15:53
@reez reez marked this pull request as ready for review January 10, 2025 16:45
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK da9027e.

Nice use of the record type in UDL!

@reez reez merged commit b235965 into bitcoindevkit:master Jan 15, 2025
25 checks passed
@reez reez deleted the gfe branch January 15, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants