Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Steps 28/29/30 of release process #656

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Steps 28/29/30 of release process #656

merged 2 commits into from
Jan 28, 2025

Conversation

reez
Copy link
Collaborator

@reez reez commented Jan 24, 2025 •
edited
Loading

Description

Steps 28/29/30 of #652

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez changed the title Steps 28/29/30 Steps 28/29/30 of release process Jan 24, 2025
@reez reez requested a review from thunderbiscuit January 27, 2025 19:52
@reez reez marked this pull request as ready for review January 27, 2025 19:52
thunderbiscuit
thunderbiscuit approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6f972a5. Nice cleanup of the changelog!

@reez
Copy link
Collaborator Author

reez commented Jan 28, 2025

Merged #659 first so I can just rebase this PR off that

@reez reez merged commit 6eb8793 into bitcoindevkit:master Jan 28, 2025
22 checks passed
@reez reez deleted the post-beta7 branch January 28, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reez @thunderbiscuit