feat(wallet): add TxBuilder::replace_tx
#1799
Conversation
| // add previous fee | ||
| if let Ok(absolute) = self.wallet.calculate_fee(&tx) { | ||
| let rate = absolute / tx.weight(); | ||
| let previous_fee = PreviousFee { absolute, rate }; | ||
| self.params.bumping_fee = Some(previous_fee); | ||
| } |
There was a problem hiding this comment.
Should we still allow replacement if we can't determine the previous tx's fee/feerate?
There was a problem hiding this comment.
ConceptACK, ApproachACK.
Just need to make sure we don't use descendant outputs from tx we are trying to replace.
It's out of the scope of this PR, the inability to set both feerate/fee amount constraints together really bothers me. We should probably switch to the bdk_coin_select crate soon.
| /// - If none of the inputs are owned by this wallet | ||
| /// | ||
| /// [`finish`]: TxBuilder::finish | ||
| pub fn replace_tx(&mut self, txid: Txid) -> Result<&mut Self, ReplaceTxError> { |
There was a problem hiding this comment.
Should probably warn that we don't help keep the original tx's recipient.
ValuedMammal
force-pushed
the
feat/replace-tx
branch
from
1e9caf4 to
3acc39b
Compare
| /// | ||
| /// # Note | ||
| /// | ||
| /// Aside from reusing one of the inputs, the method makes no assumptions about the |
There was a problem hiding this comment.
I would be wary of leaving this caveat up to documentation. The way I see it, one could either declare the recipient when calling replace_tx as a parameter or a new variant on the error path could be added for NoRecipient such that set_recipient must be called before replace_tx.
There was a problem hiding this comment.
I see what you mean, but isn't this basically true of all of the builder methods - that we don't know whether a recipient has been added until the user calls finish?
There was a problem hiding this comment.
Fair enough. Forgive my ignorance but what happens if the recipient list is empty?
There was a problem hiding this comment.
Normally it will be a NoRecipients error, unless you're doing a sweep using drain_wallet.
- Add method `TxBuilder::previous_fee` for getting the previous fee / feerate of the replaced tx.
ValuedMammal
force-pushed
the
feat/replace-tx
branch
from
3acc39b to
f753f5e
Compare
|
I made a few small changes including a test for unspendable descendants. I'm still open to discussing the right UX for |
This PR adds a new method
TxBuilder::replace_txthat offers a simple way of creating replacements without relying on the mechanics ofbuild_fee_bump. See #1374 for context and motivating discussion.In summary, there are a few limitations with the current
build_fee_bump:In contrast
replace_txis useful when we only need to create a conflict and flexible enough to further tweak the parameters as desired.Notes to the reviewers
TxBuilder::add_utxosis modified to look for potentially spent outputs, provided that the builder is in a bump-fee context.Changelog notice
TxBuilder::replace_txTxBuilder::previous_feeChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: