Add source URLs in the header summary #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
urvishp80
commented
Jul 10, 2024
•
urvishp80
commented
- include Source URLs in the header summary in markdown format
- create header summary more concise and shorter
kouloumos
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
When we discussed this change, I was thinking that the source URL would be provided separately in the JSON to be reconstructed and displayed in any hyperlink format we want to in the TLDR frontend.
That said, this looks fine. Let's proceed with this, see how it looks and iterate if necessary.
@urvishp80 feel free to merge when you resolve conflicts.
… into add-source-urls-in-summary # Conflicts: # static/homepage.json # static/newsletters/newsletter.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.