-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inactive mailing lists #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in generate_homepage_xml.py
is also responsible for generating the "Today in History" section. Although the lists are inactive, we want those sections to be created for those lists as they refer to previous posts.
I also left a couple of comments inline.
generate_weekly_newsletter_json.py
Outdated
["https://gnusha.org/pi/bitcoindev/", | ||
"https://mailing-list.bitcoindevs.xyz/bitcoindev/"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we have an array inside an array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, an array inside an array handle the unique mailing lists, e.g., bitcoin-dev have multiple domains but we want to show only one post related to in "Today in History", it doesn't affect the other logics such as Active Posts and Recent Posts.
generate_homepage_xml.py
Outdated
"https://gnusha.org/pi/bitcoindev/", | ||
["https://gnusha.org/pi/bitcoindev/", | ||
"https://mailing-list.bitcoindevs.xyz/bitcoindev/"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we have an array inside an array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above - #66 (comment)
394055d
to
e2c31a8
Compare
reopening |
@urvishp80 I mentioned the need for "Today in History" section in
why is that? |
@kouloumos We can drop these two inactive URLs from And for |
closes #65