Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inactive mailing lists #66

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

urvishp80
Copy link
Collaborator

@urvishp80 urvishp80 commented Nov 12, 2024

closes #65

@urvishp80 urvishp80 requested a review from kouloumos November 12, 2024 13:22
Copy link
Member

@kouloumos kouloumos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in generate_homepage_xml.py is also responsible for generating the "Today in History" section. Although the lists are inactive, we want those sections to be created for those lists as they refer to previous posts.

I also left a couple of comments inline.

Comment on lines 22 to 24
["https://gnusha.org/pi/bitcoindev/",
"https://mailing-list.bitcoindevs.xyz/bitcoindev/"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we have an array inside an array?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, an array inside an array handle the unique mailing lists, e.g., bitcoin-dev have multiple domains but we want to show only one post related to in "Today in History", it doesn't affect the other logics such as Active Posts and Recent Posts.

Comment on lines 50 to 51
"https://gnusha.org/pi/bitcoindev/",
["https://gnusha.org/pi/bitcoindev/",
"https://mailing-list.bitcoindevs.xyz/bitcoindev/"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we have an array inside an array?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above - #66 (comment)

src/xml_utils.py Outdated Show resolved Hide resolved
@urvishp80 urvishp80 closed this Nov 12, 2024
@urvishp80 urvishp80 force-pushed the remove-inactive-mailing-lists branch from 394055d to e2c31a8 Compare November 12, 2024 15:54
@kouloumos
Copy link
Member

reopening

@kouloumos kouloumos reopened this Nov 12, 2024
@kouloumos
Copy link
Member

@urvishp80 I mentioned the need for "Today in History" section in generate_homepage_xml.py but you also restored the new links in

  • generate_weekly_newsletter_json.py
  • push_summary_to_es.py
  • xmls_generator_production.py

why is that?

@urvishp80
Copy link
Collaborator Author

@kouloumos We can drop these two inactive URLs from xmls_generator_production.py and push_summary_to_es.py file as we are sure that there won't be any new documents from the given two mailing lists in the future.

And for generate_weekly_newsletter_json.py and generate_homepage_xml.py we need to keep them as we are using it for "Ongoing Discussions" and "Today in History/Active Posts" respectively.

@kouloumos kouloumos merged commit bf52d97 into main Nov 14, 2024
@urvishp80 urvishp80 deleted the remove-inactive-mailing-lists branch December 3, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Summarization Logic for Inactive bitcoin-dev and lightning-dev Mailing Lists
2 participants