Fixed issue where the visible attribute was not correctly converted t… #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o a boolean in TileImageLayer.
bitcraft
reviewed
Jan 6, 2021
pytmx/pytmx.py
Outdated
| @@ -1271,9 +1271,6 @@ def parse_xml(self, node): | |||
| :return: self | |||
| """ | |||
| self._set_properties(node) | |||
| self.name = node.get('name', None) | |||
There was a problem hiding this comment.
These attributes get set in the self._set_properties(node) call. That method, in TiledElement, correctly casts the values for these types in the _cast_and_set_attributes_from_node_items method.
justinbeetle
commented
Feb 5, 2021
| subnodes += find_all_visible_nodes(subnode, node_type) | ||
| return subnodes | ||
|
|
||
| for subnode in find_all_visible_nodes(node, 'layer'): | ||
| self.add_layer(TiledTileLayer(self, subnode)) |
There was a problem hiding this comment.
This only adds visible layers while previously non-visible layers were also added. If there is utility in also adding the non-visible layers, it has been lost. It could be restored with additional changes.
There was a problem hiding this comment.
I don't think we should be ignoring invisible layers. For instance, a map may have a shape layer for boundaries that might be invisible on tiled, but we still want it loaded to get the shapes.
|
Thanks been busy but I will take a look
…On Fri, Feb 5, 2021 at 2:10 PM justinbeetle ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pytmx/pytmx.py
<#133 (comment)>:
> +
+ :param node: ElementTree xml node
+ :param node_type: Tag name of elements to find
+ :return: Python list of ElementTree xml nodes
+ """
+ subnodes = []
+ for subnode in node:
+ if 'visible' in subnode.attrib and not convert_to_bool(subnode.attrib['visible']):
+ continue
+ if subnode.tag == node_type:
+ subnodes.append(subnode)
+ elif subnode.tag == 'group':
+ subnodes += find_all_visible_nodes(subnode, node_type)
+ return subnodes
+
+ for subnode in find_all_visible_nodes(node, 'layer'):
self.add_layer(TiledTileLayer(self, subnode))
This only adds visible layers while previously non-visible layers were
also added. If there is utility in also adding the non-visible layers, it
has been lost. It could be restored with additional changes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#133 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEH5JYPBAG2BTWWKT4KXLLS5RGCZANCNFSM4VTLCVBA>
.
|
…nd_all_visible_nodes in TiledMap.parse_xml to avoid rendering layers nested inside of invisible groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o a boolean in TileImageLayer.