Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bitstyles to 6.0.0 #127

Merged
merged 12 commits into from
Sep 25, 2024
Merged

Conversation

angelikatyborska
Copy link
Contributor

@angelikatyborska angelikatyborska commented Jul 2, 2024

Based on top of #125

Resolves #110 #108 #109

@angelikatyborska angelikatyborska changed the base branch from main to feature/122-upgrade-bitstyles-to-5-0-0 July 2, 2024 13:05
@angelikatyborska angelikatyborska force-pushed the upgrade-bitstyles-to-6.0.0 branch 3 times, most recently from 3b45bd9 to 8082935 Compare July 3, 2024 07:10
@angelikatyborska angelikatyborska marked this pull request as ready for review July 3, 2024 07:11
@angelikatyborska angelikatyborska force-pushed the upgrade-bitstyles-to-6.0.0 branch from 8082935 to e1a0a58 Compare July 8, 2024 09:43
Base automatically changed from feature/122-upgrade-bitstyles-to-5-0-0 to main July 9, 2024 10:08
@angelikatyborska angelikatyborska force-pushed the upgrade-bitstyles-to-6.0.0 branch from a86fa5b to cabdc5d Compare July 9, 2024 10:28
@angelikatyborska
Copy link
Contributor Author

@andreasknoepfle I ran into a surprise: the class replacements from the classnames helper do not chain... For example, there was this chain of renaming:

u-fg-grayscale-dark-2 (6.0.0) -> u-fg-text-darker (5.0.0) -> u-fg-gray-50 (4.3.0)

If I render a component that uses the class u-fg-grayscale-dark-2, and I render it for v4.3.0, it ends up with the class u-fg-text-darker instead of u-fg-gray-50 because replacements are applied backwards 🤔 (first from 5.0.0 -> 4.3.0, then from 6.0.0 -> 5.0.0).

@angelikatyborska
Copy link
Contributor Author

I ran into a surprise: the class replacements from the classnames helper do not chain... For example, there was this chain of renaming:

Will be resolved by merging #134 first

@angelikatyborska angelikatyborska force-pushed the upgrade-bitstyles-to-6.0.0 branch from cabdc5d to 46eea07 Compare September 19, 2024 12:53
@angelikatyborska
Copy link
Contributor Author

I'm pretty confident of those changes because we've been using them in the IDA backend with no hiccups

Copy link
Member

@andreasknoepfle andreasknoepfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look awesome. The only thing missing for me is an entry to the CHANGELOG.md

@angelikatyborska angelikatyborska merged commit 15ce576 into main Sep 25, 2024
3 checks passed
@angelikatyborska angelikatyborska deleted the upgrade-bitstyles-to-6.0.0 branch September 25, 2024 08:28
This was referenced Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Flash component
2 participants