Provide callback instead of doing UI tasks of calling app #49

[sunkup]

Purpose

cert4android shouldn't show the TrustCertificateActivity and a notification by itself. Instead it should execute a callback which is provided by the calling application.

Short description

• stop passing the foreground state (appInForeground) to cert4android
• start passing callback function getUserDecision and the coroutine scope in which it should run
• adapt tests

Note

I would like to avoid the delay(1000) in testCheck_MultipleDecisionsForSameCert_Negative, but I could not make it work using a countdown latch and using a mutex quickly became complicated too. I also thought of launching a 6th seperate coroutine which would watch registry.pendingDecisions.size with a while loop and release the semaphore as soon as 5 pending decisions are reached, but could not make that work either. In the end the delay(1000) is quite simple and seems to work well, but let me know if you find a cleaner way.

[rfc2822]

I see that the activity was completely removed together with all its strings (+ translations). While that the UI action should be done in the calling application, it could still be helpful to have a helping template/building block in cert4android. It's also not really the task of a calling app to know too much about certificates etc.

So I suggest to keep M3 Composables (most importantly the screen that shows the certificate contents) that could be used by the calling apps. If this would be a "big library", it should probably go into cert4android-ui-m3 or something like that, but in our case I think we can just keep it in cert4android.

[ArnyminerZ]

Works correctly

[sunkup]

@ArnyminerZ I have removed the theme and some of the dependencies

[ArnyminerZ]

Fair enough. Eventually we should move all the UI things to their own module, as Ricki said. But again, this isn't that big of a library, so I don't even think it's worth it. I'd just merge like is.