Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential exception when determining the IMA SDK version on ad start #68

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Fix potential exception when determining the IMA SDK version on ad start #68

merged 2 commits into from
Jun 27, 2024

Conversation

strangesource
Copy link
Contributor

Problem

When an IMA ad starts before MetadataOverrides are set the integration produces a NullPointerException.

Changes

  • In case of an IMA ad starting before MetadataOverrides are set report NA as ads framework version.

@strangesource strangesource self-assigned this Jun 25, 2024
@strangesource strangesource marked this pull request as ready for review June 25, 2024 04:52
zigavehovec
zigavehovec approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@zigavehovec zigavehovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@strangesource strangesource merged commit ac46e62 into develop Jun 27, 2024
2 checks passed
@strangesource strangesource deleted the fix-null-pointer branch June 27, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zigavehovec zigavehovec zigavehovec approved these changes

Assignees

@strangesource strangesource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strangesource @zigavehovec