Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report video playback data for SSAI ads #74

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

strangesource
Copy link
Contributor

@strangesource strangesource commented Jul 2, 2024

Problem

Initial ad metrics are not yet reported for SSAI ads

Changes

  • Report initial video playback metrics for server side ads
  • Report ongoing video playback metrics for ssai
  • Rename PlaybackStateProvider to PlaybackInfoProvider and add getPlaybackVideoData functionality

Related Changes

@strangesource strangesource self-assigned this Jul 2, 2024
Base automatically changed from add-ssai-api to develop July 2, 2024 14:54
@strangesource strangesource changed the base branch from develop to wire-up-ssai July 3, 2024 08:11
@strangesource strangesource force-pushed the report-initial-ad-metrics branch from 6347eb4 to 28c915b Compare July 3, 2024 08:14
Base automatically changed from wire-up-ssai to develop July 3, 2024 08:46
@strangesource strangesource changed the title Report initial ad metrics Report video playback data for SSAI ads Jul 3, 2024
@rolandkakonyi rolandkakonyi self-requested a review July 3, 2024 11:44
@strangesource strangesource marked this pull request as ready for review July 3, 2024 11:45
Copy link
Contributor

@matamegger matamegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@strangesource strangesource merged commit ce51c0b into develop Jul 3, 2024
3 checks passed
@strangesource strangesource deleted the report-initial-ad-metrics branch July 3, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants