Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unintentionally public initializers #81

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

stonko1994
Copy link
Contributor

Description

Problem

While working on adding new constructor overloads we figured out that there are constructors public which shouldn't be public.

Changes

Removing those initializers.

Checklist

  • I added an update to CHANGELOG.md file
  • I ran all the tests in the project and they succeed

@stonko1994 stonko1994 marked this pull request as ready for review August 26, 2024 07:36
Copy link
Contributor

@strangesource strangesource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. 👌

@stonko1994 stonko1994 merged commit 1c6d2f5 into develop Aug 26, 2024
3 checks passed
@stonko1994 stonko1994 deleted the feature/remove-testing-initializers branch August 26, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants