Feature/optional auto end session #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
stonko1994
reviewed
Jan 14, 2025
conviva/src/main/java/com/bitmovin/analytics/conviva/ConvivaAnalyticsIntegration.java
Show resolved
Hide resolved
I actually signed the CLA, but it won't dismiss after still... |
Looks like the commits are not associated with your email 👍 Should be fine. |
stonko1994
approved these changes
Jan 14, 2025
dyue
force-pushed
the
feature/optional-auto-end-session
branch
from
4b7125e to
6c3dcdf
Compare
I rebased to update the author email addresses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will introduce a way to not end Conviva session from player events. This allows the implementation of app specific constructs such as custom retries without Conviva repeatedly reporting VPF for each retry.