Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update invalid dependancy version in the example #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

subhanahmed047
Copy link

Fix an invalid dependancy version in the example folder that was causing the app build to fail.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@karpov-kir
Copy link
Contributor

karpov-kir commented Oct 14, 2024

@subhanahmed047, thank you for your contribution!

Could you elaborate on what issue exactly it addresses? Following https://github.com/bitmovin/bitmovin-player-react/blob/main/CONTRIBUTING.md, if I run npm run bootstrap && npm run start:dev everything works with no problems (as well as npm run build, also same for CI https://github.com/bitmovin/bitmovin-player-react/actions/runs/11122993212/job/30905468392 - the build step). I'm on MacOS, Node 18.

The dependency "bitmovin-player-react": "file:.." should be valid. This notation makes the example use local files of the bitmovin-player-react package so that when you run npm run start:dev and change files in bitmovin-player-react/src or in bitmovin-player-react/example/src they are detected and the example is recompiled on the fly. Changing "bitmovin-player-react": "file:.." -> "bitmovin-player-react": "^1.0.1" will disconnect the example from the local package files, so changes in bitmovin-player-react/src won't be detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants