Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/mlflow] Adding missing Azure Storage configuration in the Helm Chart #29626

Merged
merged 12 commits into from
Nov 15, 2024
Merged

[bitnami/mlflow] Adding missing Azure Storage configuration in the Helm Chart #29626

merged 12 commits into from
Nov 15, 2024

Conversation

eriadam
Copy link
Contributor

@eriadam eriadam commented Sep 26, 2024

Description of the change

The PR adds the missing configuration options for the Azure Storage Account in the MLFlow helm chart.

Benefits

As explained in the ticket #28569, Azure Storage is supported by MLFlow, but it is not currently possible to configure it via the Helm chart. With this change Azure Blob Storage can be configured to store the artefacts of MLFlow.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@eriadam
[bitnami/mlflow] Azure Storage Support in helm chart (#1)
c9733ce 
* Added Azure Storage Account as artefact store
* Added environment variables for azure authentication

Signed-off-by: Adam Eri <[email protected]>
@eriadam
Merge branch 'bitnami:main' into main
a7bb2d0
@github-actions github-actions bot added mlflow triage Triage is needed labels Sep 26, 2024
@github-actions github-actions bot requested a review from carrodher September 26, 2024 14:47
@eriadam eriadam mentioned this pull request Sep 26, 2024
Closed
@github-actions GitHub Actions
Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Oct 12, 2024
@github-actions GitHub Actions
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot added stale 15 days without activity and removed stale 15 days without activity labels Oct 17, 2024
@eriadam
Copy link
Contributor Author

eriadam commented Oct 17, 2024

@carrodher could you please have a look at this?

@carrodher carrodher reopened this Oct 18, 2024
@github-actions github-actions bot removed the solved label Oct 18, 2024
@github-actions github-actions bot requested a review from javsalgar October 18, 2024 12:36
@carrodher
Copy link
Member

Sorry, we didn't take a look because it is in Draft state:

This pull request is still a work in progress
Draft pull requests cannot be merged.

If you think it is ready, could you please mark it as Ready for review?

@eriadam eriadam marked this pull request as ready for review October 18, 2024 15:04
@eriadam
Copy link
Contributor Author

eriadam commented Oct 18, 2024

@carrodher Thanks, it was a draft because of the last open question in here: #28569 (comment)

Any feedback on that is much appreciated!

@carrodher carrodher requested review from jotamartos and removed request for javsalgar and carrodher October 18, 2024 15:26
@carrodher carrodher assigned jotamartos and unassigned javsalgar and carrodher Oct 18, 2024
@carrodher carrodher removed the stale 15 days without activity label Oct 18, 2024
@carrodher
Copy link
Member

Thanks! To review it in the proper status, could you please rebase from the latest changes? Apart from that, please note it's needed to grant permissions to @bitnami-bot to update your fork so it can automatically update the README, CRDs, and CHANGELOG

@eriadam
Copy link
Contributor Author

eriadam commented Oct 24, 2024

@carrodher I did both. I added bitnami bot as a member, is that OK?

@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Oct 24, 2024
@bitnami-bot
Update CHANGELOG.md
104aa87 
Signed-off-by: Bitnami Containers <[email protected]>
jotamartos
jotamartos requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but you need to rebase your branch with the latest changes in stable due to there was a new version of MLflow and there are conflicts.

@eriadam eriadam requested a review from jotamartos November 5, 2024 20:27
@bitnami-bot
Update CHANGELOG.md
475385a 
Signed-off-by: Bitnami Containers <[email protected]>
@eriadam
Copy link
Contributor Author

eriadam commented Nov 8, 2024

@jotamartos Could you please have a look?

@carrodher carrodher removed the triage Triage is needed label Nov 8, 2024
jotamartos
jotamartos requested changes Nov 14, 2024
View reviewed changes
bitnami/mlflow/Chart.yaml Outdated Show resolved Hide resolved
bitnami/mlflow/templates/tracking/deployment.yaml Outdated Show resolved Hide resolved
bitnami/mlflow/templates/tracking/deployment.yaml Outdated Show resolved Hide resolved
bitnami/mlflow/templates/tracking/deployment.yaml Outdated Show resolved Hide resolved
eriadam and others added 5 commits November 14, 2024 13:43
@eriadam @jotamartos
Update bitnami/mlflow/Chart.yaml
9d4d064 
Co-authored-by: Juan José Martos <[email protected]>
Signed-off-by: Adam Eri <[email protected]>
@eriadam @jotamartos
Update bitnami/mlflow/templates/tracking/deployment.yaml
8fd0f93 
Co-authored-by: Juan José Martos <[email protected]>
Signed-off-by: Adam Eri <[email protected]>
@eriadam @jotamartos
Update bitnami/mlflow/templates/tracking/deployment.yaml
f9bfcbb 
Co-authored-by: Juan José Martos <[email protected]>
Signed-off-by: Adam Eri <[email protected]>
@eriadam @jotamartos
Update bitnami/mlflow/templates/tracking/deployment.yaml
767b9d1 
Co-authored-by: Juan José Martos <[email protected]>
Signed-off-by: Adam Eri <[email protected]>
@bitnami-bot
Update CHANGELOG.md
7377dc1 
Signed-off-by: Bitnami Containers <[email protected]>
@eriadam
Copy link
Contributor Author

eriadam commented Nov 14, 2024

@ jotamartos Thank you, I added the changes.

@github-actions github-actions bot assigned migruiz4 and unassigned jotamartos Nov 15, 2024
@github-actions github-actions bot requested a review from migruiz4 November 15, 2024 08:44
@carrodher carrodher removed the request for review from migruiz4 November 15, 2024 08:44
@carrodher carrodher assigned jotamartos and unassigned migruiz4 Nov 15, 2024
@bitnami-bot
Update CHANGELOG.md
d4966b8 
Signed-off-by: Bitnami Containers <[email protected]>
@jotamartos jotamartos enabled auto-merge (squash) November 15, 2024 10:58
@jotamartos jotamartos merged commit 6aa1ccb into bitnami:main Nov 15, 2024
12 checks passed
sajad-sadra pushed a commit to sajad-sadra/bitnami-charts that referenced this pull request Nov 20, 2024
@eriadam @bitnami-bot
@jotamartos @sajad-sadra
[bitnami/mlflow] Adding missing Azure Storage configuration in the He…
2942452 
…lm Chart (bitnami#29626)

* [bitnami/mlflow] Azure Storage Support in helm chart (bitnami#1)

* Added Azure Storage Account as artefact store
* Added environment variables for azure authentication

Signed-off-by: Adam Eri <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* Update bitnami/mlflow/Chart.yaml

Co-authored-by: Juan José Martos <[email protected]>
Signed-off-by: Adam Eri <[email protected]>

* Update bitnami/mlflow/templates/tracking/deployment.yaml

Co-authored-by: Juan José Martos <[email protected]>
Signed-off-by: Adam Eri <[email protected]>

* Update bitnami/mlflow/templates/tracking/deployment.yaml

Co-authored-by: Juan José Martos <[email protected]>
Signed-off-by: Adam Eri <[email protected]>

* Update bitnami/mlflow/templates/tracking/deployment.yaml

Co-authored-by: Juan José Martos <[email protected]>
Signed-off-by: Adam Eri <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Adam Eri <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Co-authored-by: Bitnami Containers <[email protected]>
Co-authored-by: Juan José Martos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotamartos jotamartos jotamartos approved these changes

Assignees

@jotamartos jotamartos

Labels
mlflow solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/mlflow] Add support for Azure Storage
6 participants
@eriadam @carrodher @jotamartos @javsalgar @bitnami-bot @migruiz4