-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/redis] add extraPortsEnabled #29881
Conversation
Signed-off-by: Sepideh Alavi <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
… into headless-extraPorts
Signed-off-by: Bitnami Containers <[email protected]>
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for the late response @shecodesmagic., could you please apply the following changes?
- Since this PR adds a new value, please bump a minor version (
20.3.0
). - I think that copying the ports from the sentinel service should not be the way to proceed, since indeed they are different services that serve different purposes. Instead, I would suggest adding the value
service.headless.extraPorts
. - Please make sure that all the commits in the PR are signed, otherwise the DCO check will fail.
@migruiz4 thanks for the feedback. Ill update the PR accordingly. |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Signed-off-by: Bitnami Containers <[email protected]>
Description of the change
This change introduces an optional flag, extraPortsEnabled, allowing users to control whether the extraPorts defined for the sentinel service should also be exposed in the headless service. If set to true, the extraPorts will be exposed in the headless service.
Benefits
Allows users to expose additional ports (e.g., metrics, custom services) via the headless service for better integration and monitoring.
Provides flexibility by making this feature optional through the sentinel.service.headless.extraPortsEnabled flag.
Possible drawbacks
None known. Existing deployments without sentinel.service.headless.extraPortsEnabled set to true remain unaffected.
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm