Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] add extraPortsEnabled #29881

Closed
wants to merge 8 commits into from

Conversation

shecodesmagic
Copy link
Contributor

Description of the change

This change introduces an optional flag, extraPortsEnabled, allowing users to control whether the extraPorts defined for the sentinel service should also be exposed in the headless service. If set to true, the extraPorts will be exposed in the headless service.

Benefits

Allows users to expose additional ports (e.g., metrics, custom services) via the headless service for better integration and monitoring.
Provides flexibility by making this feature optional through the sentinel.service.headless.extraPortsEnabled flag.

Possible drawbacks

None known. Existing deployments without sentinel.service.headless.extraPortsEnabled set to true remain unaffected.

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added redis triage Triage is needed labels Oct 14, 2024
@github-actions github-actions bot requested a review from javsalgar October 14, 2024 01:58
Signed-off-by: Bitnami Containers <[email protected]>
@javsalgar javsalgar added verify Execute verification workflow for these changes in-progress labels Oct 14, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 14, 2024
@github-actions github-actions bot removed the request for review from javsalgar October 14, 2024 07:37
@github-actions github-actions bot requested a review from migruiz4 October 14, 2024 07:37
Copy link

github-actions bot commented Nov 2, 2024

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Nov 2, 2024
Copy link
Member

@migruiz4 migruiz4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the late response @shecodesmagic., could you please apply the following changes?

  • Since this PR adds a new value, please bump a minor version (20.3.0).
  • I think that copying the ports from the sentinel service should not be the way to proceed, since indeed they are different services that serve different purposes. Instead, I would suggest adding the value service.headless.extraPorts.
  • Please make sure that all the commits in the PR are signed, otherwise the DCO check will fail.

@github-actions github-actions bot removed the stale 15 days without activity label Nov 6, 2024
@shecodesmagic
Copy link
Contributor Author

@migruiz4 thanks for the feedback. Ill update the PR accordingly.

Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Nov 23, 2024
@shecodesmagic shecodesmagic deleted the headless-extraPorts branch November 24, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis solved stale 15 days without activity verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants