-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/airflow] Metrics based on StatsD #30459
Conversation
Signed-off-by: juan131 <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: juan131 <[email protected]>
Signed-off-by: juan131 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the CI is failing
Signed-off-by: juan131 <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- name: airflow-exporter | ||
image: docker.io/bitnami/airflow-exporter:0.20220314.0-debian-12-r51 | ||
- name: statsd-exporter | ||
image: docker.io/bitnami/airflow-statsd:0.28.0-debian-12-r0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be docker.io/bitnami/statsd-exporter:0.28.0-debian-12-r0
?
I though this is autogenerated by EAM, so not sure where this invalid airflow-statsd
comes from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fault! Manually edited, fixing it on a new PR
got this enabled but still only get basic metrics such as :
etc, no airflow_ metrics, anything else im missing? airflow.cfg has statsd enabled: [metrics] Edit: found the issue, with network policies enabled, statsd cant collect metrics. |
@sergiofteixeira I also faced this issue. Disabling the Network Policy helped me as well. The problem is related to the Network Policy configuration specifying the TCP protocol instead of UDP. I created a pull request (#30990) to fix this. |
thanks |
Description of the change
This PR version replaces exposing Prometheus metrics using the Airflow prometheus exporter, that exposes metrics based on the data retrieved from the database, by configuring Airflow components to send StatsD metrics to the StatsD exporter that transforms them into Prometheus metrics. Find more information about this approach in the Apache Airflow official documentation.
Benefits
Follow upstream approach for exposing metrics.
Possible drawbacks
Dashboards based on old metrics won't be valid anymore.
Applicable issues
Additional information
N/A
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm