Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/redis-cluster] feat: Set custom terminationGracePeriodSeconds for redis #30470

Merged
merged 5 commits into from
Nov 26, 2024
Merged

[bitnami/redis-cluster] feat: Set custom terminationGracePeriodSeconds for redis #30470

merged 5 commits into from
Nov 26, 2024

Conversation

sajad-sadra
Copy link
Contributor

@github-actions github-actions bot added redis-cluster triage Triage is needed labels Nov 15, 2024
@github-actions github-actions bot requested a review from javsalgar November 15, 2024 08:36
@sajad-sadra sajad-sadra changed the title Feat(redis-cluster): set custom terminationGracePeriodSeconds for redis feat(redis-cluster): Set custom terminationGracePeriodSeconds for redis Nov 15, 2024
@carrodher
Copy link
Member

Thanks for your contribution! Could you please bump the chart version in the Chart.yaml? This is necessary to test the changes and cut a new release.

In the same way, please note the DCO is also failing. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@sajad-sadra sajad-sadra force-pushed the main branch 5 times, most recently from 72f0b62 to df2b625 Compare November 24, 2024 08:55
@bitnami-bot
Update CHANGELOG.md
2dbb2cd 
Signed-off-by: Bitnami Containers <[email protected]>
@bitnami-bot
Update README.md with readme-generator-for-helm
4ab9479 
Signed-off-by: Bitnami Containers <[email protected]>
@sajad-sadra
Copy link
Contributor Author

@javsalgar
I apologize for the delay. It's ready.

@javsalgar javsalgar changed the title feat(redis-cluster): Set custom terminationGracePeriodSeconds for redis [bitnami/redis-cluster] feat: Set custom terminationGracePeriodSeconds for redis Nov 25, 2024
@github-actions github-actions bot removed the triage Triage is needed label Nov 25, 2024
@github-actions github-actions bot removed the request for review from javsalgar November 25, 2024 08:11
@github-actions github-actions bot requested a review from fmulero November 25, 2024 08:11
@bitnami-bot
Update CHANGELOG.md
cd1ffa3 
Signed-off-by: Bitnami Containers <[email protected]>
@fmulero fmulero added the verify Execute verification workflow for these changes label Nov 26, 2024
@bitnami-bot
Update CHANGELOG.md
f522d59 
Signed-off-by: Bitnami Containers <[email protected]>
fmulero
fmulero approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @sajad-sadra for your contribution!

LGTM

@fmulero fmulero merged commit 1cacaa5 into bitnami:main Nov 26, 2024
12 checks passed
@fmulero fmulero mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmulero fmulero fmulero approved these changes

Assignees

@fmulero fmulero

Labels
redis-cluster solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sajad-sadra @carrodher @fmulero @javsalgar @bitnami-bot