-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/redis] fix: update JSON schema to allow string values for values passed to tpl #30526
Conversation
…lues passed to tpl Signed-off-by: Thomas Piccioli <[email protected]>
Signed-off-by: Thomas Piccioli <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Thomas Piccioli <[email protected]>
…harts into fix-redisSchema Signed-off-by: Thomas Piccioli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to contribute but I can approve this change, sorry. There are many parameters from there that do not support a simple string to configure them (hostAliases, customLivenessProbe, customRedinessProbe, extraEnvVars, ...). As you can see, those are objects/arrays that you need to define in the values.yaml file when deploying the solution.
@jotamartos No, that's not true - per the issue #29451 and related #27319 and PR #27441 anything that is passed to the template function(s) can accept a string. Having the schema enforce not-string breaks the ability to utilize the template (see example in #29451. |
Bump @jotamartos, please re-open and re-review per the linked issues and pr |
Signed-off-by: Juan José Martos <[email protected]>
Update: I could resolve the conflicts using the UI and the changelog will be automatically generated soon. If tests pass, I'll merge the changes |
Signed-off-by: Bitnami Containers <[email protected]>
Description of the change
Updates all properties in values.schema.json that are directly passed to
tpl
to also allow for string fields.Benefits
Fixes schema to allow passing strings to
tpl
for all values that are template-ablePossible drawbacks
None
Applicable issues
Additional information
None
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm