Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/valkey] Detect non-standard images #30950

Merged
merged 4 commits into from
Dec 10, 2024
Merged

[bitnami/valkey] Detect non-standard images #30950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d099fa7
[bitnami/valkey] Detect non-standard images
Dec 10, 2024
85cf186
Modify NOTES.txt
Dec 10, 2024
c9fb02e
Update CHANGELOG.md
bitnami-bot Dec 10, 2024
7060dab
Update README.md with readme-generator-for-helm
bitnami-bot Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions bitnami/valkey/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# Changelog

## 2.1.2 (2024-12-02)
## 2.2.0 (2024-12-10)

* [bitnami/valkey] Fix broken failover in sentinel setups ([#30689](https://github.com/bitnami/charts/pull/30689))
* [bitnami/valkey] Detect non-standard images ([#30950](https://github.com/bitnami/charts/pull/30950))

## <small>2.1.2 (2024-12-05)</small>

* [bitnami/valkey] Fix broken failover in sentinel setups (#30689) ([1d3ed00](https://github.com/bitnami/charts/commit/1d3ed00f2868fbc37aee3b6adbbe29d8ef0aaa4f)), closes [#30689](https://github.com/bitnami/charts/issues/30689) [#30024](https://github.com/bitnami/charts/issues/30024)

## <small>2.1.1 (2024-12-01)</small>

Expand Down
6 changes: 3 additions & 3 deletions bitnami/valkey/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: common
repository: oci://registry-1.docker.io/bitnamicharts
version: 2.27.2
digest: sha256:6fd86cc5a4b5094abca1f23c8ec064e75e51eceaded94a5e20977274b2abb576
generated: "2024-11-29T17:24:03.100210778+01:00"
version: 2.28.0
digest: sha256:5b30f0fa07bb89b01c55fd6258c8ce22a611b13623d4ad83e8fdd1d4490adc74
generated: "2024-12-10T17:32:11.87194+01:00"
2 changes: 1 addition & 1 deletion bitnami/valkey/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ maintainers:
name: valkey
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/valkey
version: 2.1.2
version: 2.2.0
21 changes: 13 additions & 8 deletions bitnami/valkey/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,14 +428,15 @@ helm install my-release --set primary.persistence.existingClaim=PVC_NAME oci://R

### Global parameters

| Name | Description | Value |
| ----------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------ |
| `global.imageRegistry` | Global Docker image registry | `""` |
| `global.imagePullSecrets` | Global Docker registry secret names as an array | `[]` |
| `global.defaultStorageClass` | Global default StorageClass for Persistent Volume(s) | `""` |
| `global.storageClass` | DEPRECATED: use global.defaultStorageClass instead | `""` |
| `global.valkey.password` | Global Valkey password (overrides `auth.password`) | `""` |
| `global.compatibility.openshift.adaptSecurityContext` | Adapt the securityContext sections of the deployment to make them compatible with Openshift restricted-v2 SCC: remove runAsUser, runAsGroup and fsGroup and let the platform use their allowed default IDs. Possible values: auto (apply if the detected running cluster is Openshift), force (perform the adaptation always), disabled (do not perform adaptation) | `auto` |
| Name | Description | Value |
| ----------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------- |
| `global.imageRegistry` | Global Docker image registry | `""` |
| `global.imagePullSecrets` | Global Docker registry secret names as an array | `[]` |
| `global.defaultStorageClass` | Global default StorageClass for Persistent Volume(s) | `""` |
| `global.storageClass` | DEPRECATED: use global.defaultStorageClass instead | `""` |
| `global.valkey.password` | Global Valkey password (overrides `auth.password`) | `""` |
| `global.security.allowInsecureImages` | Allows skipping image verification | `false` |
| `global.compatibility.openshift.adaptSecurityContext` | Adapt the securityContext sections of the deployment to make them compatible with Openshift restricted-v2 SCC: remove runAsUser, runAsGroup and fsGroup and let the platform use their allowed default IDs. Possible values: auto (apply if the detected running cluster is Openshift), force (perform the adaptation always), disabled (do not perform adaptation) | `auto` |

### Common parameters

Expand Down Expand Up @@ -1038,6 +1039,10 @@ Find more information about how to deal with common errors related to Bitnami's

## Upgrading

### To 2.2.0

This version introduces image verification for security purposes. To disable it, set `global.security.allowInsecureImages` to `true`. More details at [GitHub issue](https://github.com/bitnami/charts/issues/30850).

### To 2.0.0

This major updates all the references from `master/slave` to `primary/replica` to follow the upstream project strategy:
Expand Down
3 changes: 2 additions & 1 deletion bitnami/valkey/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,4 +210,5 @@ YOU NEED TO PERFORM AN UPGRADE FOR THE SERVICES AND WORKLOAD TO BE CREATED
{{- $resourceSections = append $resourceSections "primary" -}}
{{- end }}
{{- include "common.warnings.resources" (dict "sections" $resourceSections "context" $) }}
{{- include "common.warnings.modifiedImages" (dict "images" (list .Values.image .Values.sentinel.image .Values.metrics.image .Values.volumePermissions.image .Values.kubectl.image) "context" $) }}
{{- include "common.warnings.modifiedImages" (dict "images" (list .Values.image .Values.sentinel.image .Values.metrics.image .Values.volumePermissions.image .Values.kubectl.image) "context" $) }}
{{- include "common.errors.insecureImages" (dict "images" (list .Values.image .Values.sentinel.image .Values.metrics.image .Values.volumePermissions.image .Values.kubectl.image) "context" $) }}
5 changes: 5 additions & 0 deletions bitnami/valkey/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ global:
imagePullSecrets: []
defaultStorageClass: ""
storageClass: ""
## Security parameters
##
security:
## @param global.security.allowInsecureImages Allows skipping image verification
allowInsecureImages: false
valkey:
password: ""
## Compatibility adaptations for Kubernetes platforms
Expand Down
Loading