[bitnami/clickhouse] Fix: bind ipv6 and ipv4 by default

[JulesdeCube]

Note

This PR is re-open of #31168 (see #31168 (comment))

Motivation

The current clickhouse helm chart don't support ipv6 only cluster.

Context

By default clickhouse bind localhost on ipv4 and ipv6 (see https://github.com/ClickHouse/ClickHouse/blob/master/programs/server/config.xml#L253).

The bitnami container override this behaviors and bind to any ipv4 by passing -- --listen_host=0.0.0.0 to clickhouse-server via the CMD (see https://github.com/bitnami/containers/blob/main/bitnami/clickhouse/24/debian-12/Dockerfile#L60).
this is easily override to listen on ivp6 by changing the container command to /opt/bitnami/scripts/clickhouse/run.sh -- --listen_host="::".

The helm chart use an hard coded script as it's entry with no possibility to pass/override argument to clickhouse-server. (see https://github.com/bitnami/charts/blob/main/bitnami/clickhouse/templates/scripts-configmap.yaml)

Description of the change

this PR:

• remove the default clickhouse-server arguments.
• allow to specify clickhouse-server arguments.
• use the defaultConfigurationOverrides to listen on ipv4 and ipv6

Benefits

Add Support for ipv6 only cluster

Possible drawbacks

It's harder to change listen_host in the xml config file.

Applicable issues

related with OneUptime/oneuptime#1348

Additional information

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)

[carrodher]

I just accepted the invitation on behalf of @bitnami-bot and the job is running again. If everything is ok, a new commit should be added authored by the bot

[carrodher]

It seems there is still something wrong with the permission:

remote: Permission to JulesdeCube/bitnami-charts.git denied to bitnami-bot.
fatal: unable to access 'https://github.com/JulesdeCube/bitnami-charts/': The requested URL returned error: 403

[JulesdeCube]

hello I manage to fix the probleme by running the CI localy and push the change.

[fmulero]

The 403 error is still happening. Please check if the @bitnami-bot user appears as collaborator in your repository https://github.com/JulesdeCube/bitnami-charts and you don't have protection rule set for this branch

[fmulero]

Hi @JulesdeCube
The 403 error was in our side, the invitation was not managed properly.

About your changes I think we should keep IPv4 by default. If we enable IPV6 by default, the containers won't start properly in those systems without IPv6 support. Users who need IPv6 could enable it changing the value defaultConfigurationOverrides, setting the value extraOverrides or adding -- --listen_host=:: to the args value

[JulesdeCube]

Hello,

I add listen_reuse_port and listen_try (ClickHouse/ClickHouse#21591 (comment)) to defaultConfigurationOverrides to fix 2 issues.

I also properly test the new solution on a ipv4 only server.

But still have some error on the CI:

Error: Task helm-package with ID e948fb94-776e-4a67-a636-1da00c492323 has failed. Error: Error executing action, program exited with exit code: 1, stderr: ERROR: Packaging chart: Couldn't package chart. Error: found in Chart.yaml, but missing in charts/ directory: zookeeper, common

[fmulero]

Enable listen_reuse_port is not recommended by mongodb. I think we should keep it simple and just allow users to enable easily IPv6 keeping IPv4 by default.

NOTE: The CI error was caused by a problem in our configuration. It is now working.

[JulesdeCube]

I remove listen_reuse_port (as it's not recommended).

But i think that native ipv4 and ipv6 support must be the default behavior. Moreover this work on only ipv4 only stack

[fmulero]

Then please bump the chart version and fix the conflicts. I'll keep an eye on this to merge it

[JulesdeCube]

hello,

I was wondering what is blocking this pr to be merge ?