-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/seaweedfs]: add pod for weed iam
#31334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Crasset <[email protected]>
Signed-off-by: Tom Crasset <[email protected]>
Signed-off-by: Tom Crasset <[email protected]>
tcrasset
force-pushed
the
tc/add-seaweedfs-iam
branch
from
January 13, 2025 11:19
14b8f2a
to
2fb5465
Compare
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Execute verification workflow for these changes
in-progress
labels
Jan 13, 2025
Signed-off-by: Tom Crasset <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
alvneiayu
previously approved these changes
Jan 20, 2025
Signed-off-by: Alvaro Neira Ayuso <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
alvneiayu
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This adds a pod starting the IAM API from
weed
.Benefits
This will allow adding per-user access control on different parts of the file tree.
Possible drawbacks
There is no TLS communication to
iam
, nor is there anygrpc
.Applicable issues
weed iam
container #31331Additional information
I copy pasted the values and files from
bitnami/seaweedfs/templates/wedadv/
(yes there is a typo forwebdav
in the path) and modified them accordingly. I deleted a few files that I thought were not useful for a first implementation, namely:networkpolicy.yaml
cert.yaml
hpa.yaml
ingress.yaml
andingress-tls-secret.yaml
tls-secret.yaml
The respective fields in
values.yaml
were deleted too.Note that I did this without the use of
GIT_ROOT/template/CHART_NAME
. Please tell me if I should have.Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm