Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/seaweedfs]: add pod for weed iam #31334

Merged
merged 8 commits into from
Jan 20, 2025

Conversation

tcrasset
Copy link
Contributor

@tcrasset tcrasset commented Jan 13, 2025

Description of the change

This adds a pod starting the IAM API from weed.

Benefits

This will allow adding per-user access control on different parts of the file tree.

Possible drawbacks

There is no TLS communication to iam, nor is there any grpc.

Applicable issues

Additional information

I copy pasted the values and files from bitnami/seaweedfs/templates/wedadv/ (yes there is a typo for webdav in the path) and modified them accordingly. I deleted a few files that I thought were not useful for a first implementation, namely:

  • networkpolicy.yaml
  • cert.yaml
  • hpa.yaml
  • ingress.yaml and ingress-tls-secret.yaml
  • tls-secret.yaml

The respective fields in values.yaml were deleted too.

Note that I did this without the use of GIT_ROOT/template/CHART_NAME. Please tell me if I should have.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Tom Crasset <[email protected]>
Signed-off-by: Tom Crasset <[email protected]>
Signed-off-by: Tom Crasset <[email protected]>
@tcrasset tcrasset force-pushed the tc/add-seaweedfs-iam branch from 14b8f2a to 2fb5465 Compare January 13, 2025 11:19
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher marked this pull request as ready for review January 13, 2025 11:53
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 13, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 13, 2025
@github-actions github-actions bot removed the request for review from javsalgar January 13, 2025 11:54
@github-actions github-actions bot requested a review from alvneiayu January 13, 2025 11:54
tcrasset and others added 2 commits January 14, 2025 10:42
Signed-off-by: Bitnami Containers <[email protected]>
alvneiayu
alvneiayu previously approved these changes Jan 20, 2025
Signed-off-by: Bitnami Containers <[email protected]>
@alvneiayu alvneiayu merged commit 5f5a702 into bitnami:main Jan 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seaweedfs solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/seaweedfs] Add weed iam container
5 participants