[bitnami/rabbitmq] Fix incorrect configuration of TCP listen options by memoryHighWatermark settings #31336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional Signed-off-by: Michal Klinka <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
juan131
requested changes
Jan 13, 2025
bitnami/rabbitmq/values.yaml
Outdated
| ## TCP Listen Options | ||
| ## | ||
| {{- if .Values.tcpListenOptions.enabled }} |
There was a problem hiding this comment.
This "if" should be included before the comment in line 518
Signed-off-by: Michal Klinka <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes a small bug reported in #31221. It fixes a bug, which made configuring tcpClientOptions impossible, if memoryHighWatermark was disabled.
Benefits
Makes tcpClientOptions configurable independently from memoryHighWatermark
Possible drawbacks
Applicable issues
Additional information
As of now, the memoryHighWatermark is disabled by default, which the default bitnami tcpClientOptions are disabled as well. This PR makes them configurable using
tcpClientOptions.enabledfield, and makes the fieldtrueby default.Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm