-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few minor improvements #75
Conversation
@@ -54,7 +54,7 @@ | |||
"dependencies": { | |||
"bitcore": "^0.12.0", | |||
"bloom-filter": "^0.2.0", | |||
"buffers": "^0.1.1", | |||
"buffers": "olalonde/node-buffers", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to node-buffers look good, however this references an unpublished master branch. There are a few open issues, #52 and #32 with node-buffers already. I believe we only use a small portion of the implemented methods, so we may be able to make this a part of this codebase, since we're also adding the skip method. However we can take care of this in another PR as well as the deprecation warnings.
Thanks for the comments, will update the PR tomorrow. |
Any update? Will this ever be approved and merged? |
Needs a rebase on master. It would be good to fix the issues related to |
Inventory.prototype.typeName
methodAdd optional callback to
Peer.prototype.sendMessage
Get rid of deprecation warning caused by node-buffers library.