Defect: NettyStreamingService.disconnect() method does not shutdown a…

[pchertalev]

…ll threads - FIXED

• FIX NullPointerException on first "partial"

Looks like it is fix of bugs: #145 #35

[Flemingjp]

NettyStreamService - What is the purpose of creating a new instance of an NioEvent?

[badgerwithagun]

Pretty sure #191 resolves this. There were quite a few edge cases it took a while to iron out.

[Flemingjp]

Recommdation would be to close this PR?

[badgerwithagun]

I'm going to try merging this locally to see the differences in place. WIll report back

[badgerwithagun]

OK, so it's a mixed bag.

• The changes to the *Example.java files should be merged.
• The change to BitmexStreamingMarketDataService is already implemented in Fix gdax disconnect NPE/Bitmex execution reports/bug-fix rollup #191. The version in Fix gdax disconnect NPE/Bitmex execution reports/bug-fix rollup #191 is slightly safer (immutable) but they do the same thing.
• The changes to NettyStreamingService are sensible too, and also again implemented in Fix gdax disconnect NPE/Bitmex execution reports/bug-fix rollup #191. However, I'm unsure about the differences. Fix gdax disconnect NPE/Bitmex execution reports/bug-fix rollup #191 switches to a 2-thread event loop group and I don't know why (I didn't write it). There's usually a reason for this stuff. There's also extra logging in Fix gdax disconnect NPE/Bitmex execution reports/bug-fix rollup #191.

This is a good PR. If it's merged before #191 it would be beneficial on its own. However, it would be a pain to fix up #191 again so it merges, and that would screw up the cleanup proposal I put in #224.

My preference would be to get #191 merged first, then follow up with this when we can make a choice about the event group thread count question.

[Flemingjp]

Ok, this should be put on hold until we can merge #191

[pchertalev]

No problemo. I will resolve conflicts after merge #191

[Flemingjp]

@pchertalev #191 has now been merged. If you could test to see if the problem still exits, and requires this PR that'd be great