Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example of smoltcp echo server #512

Merged
merged 13 commits into from
Oct 7, 2024
Merged

Add example of smoltcp echo server #512

merged 13 commits into from
Oct 7, 2024

Conversation

lmbollen
Copy link
Contributor

Add all rust code for the smoltcp echo server

@lmbollen lmbollen force-pushed the add-smoltcp-example branch 4 times, most recently from da62f07 to 3fc68a2 Compare April 23, 2024 14:20
@bittide bittide deleted a comment from google-cla bot Apr 23, 2024
@lmbollen lmbollen force-pushed the add-smoltcp-example branch 2 times, most recently from 5b410c8 to a3e25c6 Compare April 23, 2024 14:35
@lmbollen lmbollen changed the base branch from staging to add-wishbone-packet-buffers May 1, 2024 12:51
@lmbollen lmbollen force-pushed the add-wishbone-packet-buffers branch from 572e896 to f459c53 Compare May 29, 2024 09:31
@lmbollen lmbollen force-pushed the add-wishbone-packet-buffers branch 2 times, most recently from e4f3f01 to 95b6fdc Compare June 11, 2024 14:35
@lmbollen lmbollen force-pushed the add-wishbone-packet-buffers branch 2 times, most recently from af57deb to 045dc88 Compare July 4, 2024 14:11
@martijnbastiaan martijnbastiaan mentioned this pull request Jul 4, 2024
Open
3 tasks
@lmbollen lmbollen force-pushed the add-wishbone-packet-buffers branch 2 times, most recently from 8e96a75 to 0641dbf Compare July 8, 2024 09:26
@lmbollen lmbollen force-pushed the add-wishbone-packet-buffers branch 3 times, most recently from 106eb8c to 6b252f9 Compare July 9, 2024 06:58
@lmbollen lmbollen force-pushed the add-smoltcp-example branch 4 times, most recently from 3d5e08b to 8cf8030 Compare July 15, 2024 15:07
@lmbollen lmbollen force-pushed the add-wishbone-packet-buffers branch from 6b252f9 to ae2d9e5 Compare July 16, 2024 07:37
@lmbollen lmbollen changed the base branch from add-wishbone-packet-buffers to smoltcp-bitide-instance July 16, 2024 12:54
@lmbollen lmbollen force-pushed the add-smoltcp-example branch 2 times, most recently from 44c4ed4 to 4182732 Compare October 3, 2024 14:14
rslawson
rslawson reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@rslawson rslawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real complaints about the actual code itself, more just some style/readability things. Except for the one note on lines 96-97 of firmware-support/bittide-sys/src/axi.rs. I'm happy with basically everything else otherwise.

firmware-support/bittide-sys/src/smoltcp/axi.rs Outdated Show resolved Hide resolved
firmware-support/bittide-sys/Cargo.toml Outdated Show resolved Hide resolved
firmware-support/bittide-sys/src/axi.rs Outdated Show resolved Hide resolved
firmware-support/bittide-sys/src/axi.rs Outdated Show resolved Hide resolved
firmware-support/bittide-sys/src/axi.rs Show resolved Hide resolved
firmware-support/bittide-sys/src/axi/self_test.rs Outdated Show resolved Hide resolved
firmware-support/bittide-sys/src/axi/self_test.rs Outdated Show resolved Hide resolved
@lmbollen lmbollen force-pushed the add-smoltcp-example branch 2 times, most recently from c114baf to e26935f Compare October 7, 2024 09:23
rslawson
rslawson reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@rslawson rslawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the previous two comments I left. My only other request would be to run a ./cargo.sh fmt from the base of the repo before resolving the PR.

@lmbollen lmbollen dismissed hydrolarus’s stale review October 7, 2024 09:53

Changes implemented

@lmbollen lmbollen requested a review from rslawson October 7, 2024 09:55
@lmbollen
Small axi HAL refactor:
0cb2c31 
* Utilize type level `BUF_SIZE`  to derive address offsets
* Add `debug_assert` to check `copy_overlapping` invariant in debug builds
@lmbollen
axi::self_test readability refactor
830c765
@lmbollen
Fix smoltcp version to 0.11
3efa1b8
@lmbollen lmbollen changed the title Add smoltcp example Add example of smoltcp echo server Oct 7, 2024
@lmbollen lmbollen merged commit ef03ab4 into staging Oct 7, 2024
27 checks passed
@lmbollen lmbollen deleted the add-smoltcp-example branch October 7, 2024 11:06
@rslawson rslawson mentioned this pull request Oct 9, 2024
Merged
@lmbollen lmbollen mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rslawson rslawson rslawson approved these changes

@hydrolarus hydrolarus hydrolarus left review comments

Assignees
No one assigned
Labels
2024H1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lmbollen @hydrolarus @rslawson @martijnbastiaan