-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-11176: Update generator to use segmented control #4075
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4075 +/- ##
==========================================
- Coverage 88.92% 88.89% -0.03%
==========================================
Files 432 432
Lines 35671 35648 -23
Branches 5241 5242 +1
==========================================
- Hits 31720 31689 -31
- Misses 2115 2119 +4
- Partials 1836 1840 +4 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
520d940
to
19fb2d8
Compare
@@ -46,6 +46,7 @@ fun BitwardenSegmentedButton( | |||
) { | |||
options.forEachIndexed { index, option -> | |||
SegmentedButton( | |||
enabled = option.isEnabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
GeneratorState.MainType.Passphrase() | ||
} | ||
|
||
null -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice
19fb2d8
to
f856f8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dseverns-livefront |
🎟️ Tracking
PM-11176
📔 Objective
This PR updates the Generator Screen to use a Segmented Control for top level navigation.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes