Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-11176: Update generator to use segmented control #4075

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Oct 11, 2024

🎟️ Tracking

PM-11176

📔 Objective

This PR updates the Generator Screen to use a Segmented Control for top level navigation.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 89.96656% with 30 lines in your changes missing coverage. Please review.

Project coverage is 88.89%. Comparing base (8eab74d) to head (f856f8b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...n/ui/tools/feature/generator/GeneratorViewModel.kt 89.59% 8 Missing and 15 partials ⚠️
...rden/ui/tools/feature/generator/GeneratorScreen.kt 91.02% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4075      +/-   ##
==========================================
- Coverage   88.92%   88.89%   -0.03%     
==========================================
  Files         432      432              
  Lines       35671    35648      -23     
  Branches     5241     5242       +1     
==========================================
- Hits        31720    31689      -31     
- Misses       2115     2119       +4     
- Partials     1836     1840       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Logo
Checkmarx One – Scan Summary & Details7791997a-26c9-4128-9e7b-76a8c5a35c5a

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/utils/GeneratorRepositoryExtensions.kt: 11 Attack Vector
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 27 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Use_of_Hardcoded_Password /app/src/main/java/com/x8bit/bitwarden/data/autofill/util/HtmlInfoExtensions.kt: 20 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 349
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 349
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 241

@david-livefront david-livefront force-pushed the PM-11176-generator-segmented-control branch 2 times, most recently from 520d940 to 19fb2d8 Compare October 14, 2024 19:29
@@ -46,6 +46,7 @@ fun BitwardenSegmentedButton(
) {
options.forEachIndexed { index, option ->
SegmentedButton(
enabled = option.isEnabled,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

GeneratorState.MainType.Passphrase()
}

null -> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@david-livefront david-livefront force-pushed the PM-11176-generator-segmented-control branch from 19fb2d8 to f856f8b Compare October 14, 2024 20:20
Copy link
Collaborator

@dseverns-livefront dseverns-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-livefront
Copy link
Collaborator Author

Thanks @dseverns-livefront

@david-livefront david-livefront added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit efbf842 Oct 14, 2024
9 checks passed
@david-livefront david-livefront deleted the PM-11176-generator-segmented-control branch October 14, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants