-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-13471 Remove instances deprecated ClickableText #4076
Conversation
New Issues
Fixed Issues
|
end = endIndexPrivacy, | ||
) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanna drop the newline here
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4076 +/- ##
==========================================
+ Coverage 88.87% 88.89% +0.02%
==========================================
Files 429 429
Lines 35529 35505 -24
Branches 5235 5231 -4
==========================================
- Hits 31575 31563 -12
+ Misses 2121 2108 -13
- Partials 1833 1834 +1 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13471
📔 Objective
ClickableText
is deprecated, moving to usingLinkAnnotation
with theText
function.📸 Screenshots
Tested and verified with existing links.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes