Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BITAU-176 Filter out deleted ciphers from syncAccounts call #4078

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ahaisting-livefront
Copy link
Collaborator

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-176

📔 Objective

Make sure we don't show deleted ciphers when syncing with the authenticator app.

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Oct 12, 2024

Logo
Checkmarx One – Scan Summary & Detailsca466eb3-585c-4541-9c7d-d2112619159c

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/utils/GeneratorRepositoryExtensions.kt: 11 Attack Vector
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 27 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Use_of_Hardcoded_Password /app/src/main/java/com/x8bit/bitwarden/data/autofill/util/HtmlInfoExtensions.kt: 20 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 349
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 349
MEDIUM Privacy_Violation /app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 241

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.92%. Comparing base (8eab74d) to head (74dcd26).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rm/repository/AuthenticatorBridgeRepositoryImpl.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4078   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files         432      432           
  Lines       35671    35671           
  Branches     5241     5241           
=======================================
  Hits        31720    31720           
  Misses       2115     2115           
  Partials     1836     1836           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SaintPatrck
SaintPatrck previously approved these changes Oct 14, 2024
@ahaisting-livefront ahaisting-livefront added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 14, 2024
@ahaisting-livefront ahaisting-livefront added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 2b87cda Oct 14, 2024
9 checks passed
@ahaisting-livefront ahaisting-livefront deleted the filter-deleted-items branch October 14, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants