Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-3953] Generalize copy for login with device (clients) #12729

Merged

Conversation

alec-livefront
Copy link
Collaborator

@alec-livefront alec-livefront commented Jan 7, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-3953?atlOrigin=eyJpIjoiNmU1NjhhMGRmZmUyNDUyNDgxZDc3YzAzMGI2MDliNjgiLCJwIjoiaiJ9

📔 Objective

Updates the title, content and CTA translations for the "Login with device" modal that pops up after initializing a login with device request. Note that the "Receiving device alert when minimized (desktop only)" seems flaky - I was only able to get it to show up seemingly randomly.

📸 Screenshots

Screenshot 2025-01-07 at 9 19 00 AM

Screenshot 2025-01-15 at 4 19 15 PM
GMT20250115-211533_Clip_Alec.Rippberger.s.Clip.01_15_2025.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Logo
Checkmarx One – Scan Summary & Details723a0ae9-8a43-4b0e-b8f7-1b4694a1d45e

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 35.49%. Comparing base (91509f2) to head (42a1ba3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...a-auth-request/login-via-auth-request.component.ts 0.00% 5 Missing ⚠️
.../components/login-via-auth-request-v1.component.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12729      +/-   ##
==========================================
- Coverage   35.49%   35.49%   -0.01%     
==========================================
  Files        3007     3007              
  Lines       90888    90896       +8     
  Branches    16907    16908       +1     
==========================================
  Hits        32260    32260              
- Misses      56126    56134       +8     
  Partials     2502     2502              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alec-livefront alec-livefront marked this pull request as ready for review January 15, 2025 22:51
@alec-livefront alec-livefront requested review from a team as code owners January 15, 2025 22:51
@alec-livefront alec-livefront requested a review from rr-bw January 15, 2025 22:51
mzieniukbw
mzieniukbw previously approved these changes Jan 16, 2025
Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KM changes looks good

@alec-livefront alec-livefront requested a review from rr-bw January 22, 2025 21:23
@alec-livefront alec-livefront added the needs-qa Marks a PR as requiring QA approval label Jan 22, 2025
alec-livefront and others added 8 commits January 23, 2025 12:39
Update apps/browser/src/auth/popup/login-via-auth-request-v1.component.html

Co-authored-by: Maciej Zieniuk <[email protected]>
Update apps/desktop/src/auth/login/login-via-auth-request-v1.component.html

Co-authored-by: Maciej Zieniuk <[email protected]>
Update libs/auth/src/angular/login-via-auth-request/login-via-auth-request.component.html

Co-authored-by: Maciej Zieniuk <[email protected]>
mzieniukbw
mzieniukbw previously approved these changes Jan 23, 2025
@alec-livefront alec-livefront requested a review from rr-bw January 23, 2025 21:01
Copy link
Contributor

@rr-bw rr-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, then I think we're good to go.

apps/web/src/locales/en/messages.json Show resolved Hide resolved
@alec-livefront alec-livefront removed the needs-qa Marks a PR as requiring QA approval label Jan 31, 2025
@alec-livefront alec-livefront merged commit 8e70d5b into main Jan 31, 2025
84 checks passed
@alec-livefront alec-livefront deleted the auth/pm-3953/generalize-copy-for-login-with-device branch January 31, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants