-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-3953] Generalize copy for login with device (clients) #12729
[PM-3953] Generalize copy for login with device (clients) #12729
Conversation
This reverts commit 650cbd2.
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12729 +/- ##
==========================================
- Coverage 35.49% 35.49% -0.01%
==========================================
Files 3007 3007
Lines 90888 90896 +8
Branches 16907 16908 +1
==========================================
Hits 32260 32260
- Misses 56126 56134 +8
Partials 2502 2502 ☔ View full report in Codecov by Sentry. |
…ttps://github.com/bitwarden/clients into auth/pm-3953/generalize-copy-for-login-with-device
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KM changes looks good
apps/desktop/src/auth/login/desktop-login-approval-component.service.ts
Outdated
Show resolved
Hide resolved
apps/desktop/src/auth/login/login-via-auth-request-v1.component.html
Outdated
Show resolved
Hide resolved
libs/auth/src/angular/login-via-auth-request/login-via-auth-request.component.html
Outdated
Show resolved
Hide resolved
apps/browser/src/auth/popup/login-via-auth-request-v1.component.html
Outdated
Show resolved
Hide resolved
apps/desktop/src/auth/login/login-via-auth-request-v1.component.html
Outdated
Show resolved
Hide resolved
libs/auth/src/angular/login-via-auth-request/login-via-auth-request.component.html
Outdated
Show resolved
Hide resolved
Update apps/browser/src/auth/popup/login-via-auth-request-v1.component.html Co-authored-by: Maciej Zieniuk <[email protected]>
Update apps/desktop/src/auth/login/login-via-auth-request-v1.component.html Co-authored-by: Maciej Zieniuk <[email protected]>
Update libs/auth/src/angular/login-via-auth-request/login-via-auth-request.component.html Co-authored-by: Maciej Zieniuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change, then I think we're good to go.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-3953?atlOrigin=eyJpIjoiNmU1NjhhMGRmZmUyNDUyNDgxZDc3YzAzMGI2MDliNjgiLCJwIjoiaiJ9
📔 Objective
Updates the title, content and CTA translations for the "Login with device" modal that pops up after initializing a login with device request. Note that the "Receiving device alert when minimized (desktop only)" seems flaky - I was only able to get it to show up seemingly randomly.
📸 Screenshots
GMT20250115-211533_Clip_Alec.Rippberger.s.Clip.01_15_2025.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes