Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16447] Disable preserve whitespaces #12994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 21, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16447

📔 Objective

Angular 6 changed the default to not preserve whitespaces. We've continued to opt into this pattern for backwards compatibility but we're experiencing issues with the new control flow syntax and would therefore like to switch and not preserve whitespace any longer.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner January 21, 2025 10:03
@Hinton Hinton requested a review from vleague2 January 21, 2025 10:03
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsca4ac2a1-bb3a-4de4-b9c3-7ef103114019

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 34.96%. Comparing base (c6a3055) to head (92566c1).
Report is 20 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/browser/src/popup/main.ts 0.00% 1 Missing ⚠️
apps/desktop/src/app/main.ts 0.00% 1 Missing ⚠️
apps/web/src/main.ts 0.00% 1 Missing ⚠️
bitwarden_license/bit-web/src/main.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12994   +/-   ##
=======================================
  Coverage   34.96%   34.96%           
=======================================
  Files        2976     2976           
  Lines       90585    90585           
  Branches    16980    16980           
=======================================
  Hits        31671    31671           
  Misses      56457    56457           
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Storybook diffs? Suspicious...

@willmartian willmartian added the needs-qa Marks a PR as requiring QA approval label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants