Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-16952] Update text color for description in claimed domains page #13011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Jan 22, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-16952

📔 Objective

domain-verification.component.html: "claimedDomainsDesc" is currently using tw-text-muted when it should be using tw-text-main

📸 Screenshots

Before:
image

After:
image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@r-tome r-tome marked this pull request as ready for review January 22, 2025 15:28
@r-tome r-tome requested a review from a team as a code owner January 22, 2025 15:28
@r-tome r-tome requested a review from eliykat January 22, 2025 15:28
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsf32a05e1-d4b4-48fe-96d6-dd9064ec5a4f

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.18%. Comparing base (e26670c) to head (c141223).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13011   +/-   ##
=======================================
  Coverage   35.18%   35.18%           
=======================================
  Files        2991     2991           
  Lines       90608    90608           
  Branches    16950    16950           
=======================================
  Hits        31876    31876           
  Misses      56270    56270           
  Partials     2462     2462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty simple change but I wonder whether we should be using our typography styles instead. I've raised the question on the Jira ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants