Simplelogin alias generation only generate random words instead the domain name #13024
+65
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (10)Checkmarx found the following issues in this Pull Request
|
albertboyd5
changed the title
1 task
|
⛏️ Please include a video demonstrating the new functionality. |
audreyality
requested changes
Jan 23, 2025
There was a problem hiding this comment.
📝 This change also needs to be applied to credential-generator.component.ts.
There was a problem hiding this comment.
🤔 Was this change requested by the vault team? The solution analysis indicates the website should be passed using an attribute on the component, not a new service.
If the vault team did ask for this service to be created, then it should be integrated within their component, not the shared tools component.
| @@ -66,6 +67,7 @@ export class UsernameGeneratorComponent implements OnInit, OnDestroy { | |||
| private accountService: AccountService, | |||
| private zone: NgZone, | |||
| private formBuilder: FormBuilder, | |||
| private cipherFormUriService: CipherFormUriService, | |||
There was a problem hiding this comment.
❌ This couples the username generator to the vault. At present, the vault is the only consumer, but it's not the only one. Rewrite this to use an attribute.
Comment on lines
+3
to
+4
| // eslint-disable-next-line import/no-restricted-paths | ||
| import { Injectable } from "@angular/core"; |
There was a problem hiding this comment.
❌ The lint is correct. @bitwarden/common may not depend upon angular dependencies. Services implemented in common should be manually configured using the JsLibServiceModule.
Comment on lines
+1
to
+2
| // FIXME: Update this file to be type safe and remove this and next line | ||
| // @ts-strict-ignore |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16171
📔 Objective
This PR addresses the issue where the Simplelogin alias generator creates random words instead of including the current website's domain name. The new implementation ensures that aliases are generated based on the active website domain and updates the Simplelogin alias note appropriately.
The alias should be generated in the format [email protected], where website is derived from the current browser tab's domain.
The alias note in Simplelogin should include:
Website: www.website.com. Generated by Bitwarden.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes