-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fido2 2FA on Linux #13038
base: km/fido-2-on-mac
Are you sure you want to change the base?
Enable fido2 2FA on Linux #13038
Conversation
New Issues (4)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## km/fido-2-on-mac #13038 +/- ##
=================================================
Coverage 34.34% 34.34%
=================================================
Files 2965 2965
Lines 90515 90514 -1
Branches 16977 16976 -1
=================================================
Hits 31086 31086
+ Misses 56965 56964 -1
Partials 2464 2464 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
📔 Objective
Electron on Linux just supports fido2, same thing as with mac applies, no pinentry.
Sandboxed linux (snap/flatpak) need some further permissions before they can be enabled.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes