Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group linting dependencies #13049

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Group linting dependencies #13049

merged 2 commits into from
Jan 27, 2025

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 24, 2025

🎟️ Tracking

📔 Objective

Only create a single lint related PR for minor and patch releases.

It should be mostly safe to group linting dependencies together. Sometimes there are "breaking" changes but generally we want to adopt them either way and it's a matter of ignoring the new instances.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from trmartin4 January 24, 2025 10:55
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Logo
Checkmarx One – Scan Summary & Details3d1cfbe6-a362-4b6d-8dba-d7348786bacb

New Issues (32)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
CRITICAL CVE-2024-12692 Npm-electron-33.3.1 Vulnerable Package
CRITICAL CVE-2024-12694 Npm-electron-33.3.1 Vulnerable Package
CRITICAL CVE-2024-12695 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-11112 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-11113 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-11114 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-11115 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-11395 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-12053 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-12381 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-12382 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2024-12693 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0291 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0434 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0436 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0437 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0438 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0443 Npm-electron-33.3.1 Vulnerable Package
HIGH CVE-2025-0447 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2024-11110 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2024-11111 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2024-11116 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2024-11117 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0435 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0439 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0440 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0441 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0442 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0446 Npm-electron-33.3.1 Vulnerable Package
MEDIUM CVE-2025-0448 Npm-electron-33.3.1 Vulnerable Package
LOW Client_Hardcoded_Domain /apps/web/src/app/billing/shared/payment/payment.component.ts: 75
detailsThe JavaScript file imported in "https://js\.stripe\.com/v3/?advancedFraudSignals=false" in /apps/web/src/app/billing/shared/payment/payment.componen...
Attack Vector
LOW Client_Hardcoded_Domain /apps/web/src/app/billing/shared/payment/payment.component.ts: 75
detailsThe JavaScript file imported in "https://js\.stripe\.com/v3/?advancedFraudSignals=false" in /apps/web/src/app/billing/shared/payment/payment.componen...
Attack Vector

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.24%. Comparing base (4cbace9) to head (905ef38).
Report is 31 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13049      +/-   ##
==========================================
+ Coverage   35.10%   35.24%   +0.13%     
==========================================
  Files        3000     2997       -3     
  Lines       91320    90887     -433     
  Branches    17094    16973     -121     
==========================================
- Hits        32062    32034      -28     
+ Misses      56754    56365     -389     
+ Partials     2504     2488      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/renovate.json Outdated Show resolved Hide resolved
@Hinton Hinton requested a review from trmartin4 January 27, 2025 11:42
@Hinton Hinton merged commit 9fe84c3 into main Jan 27, 2025
22 of 23 checks passed
@Hinton Hinton deleted the arch/group-lint branch January 27, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants