[PM-17182] Remove Bootstrap style from EnvironmentSelectorComponent #13193
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (1872)Checkmarx found the following issues in this Pull Request
Fixed Issues (54)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13193 +/- ##
==========================================
- Coverage 35.41% 35.41% -0.01%
==========================================
Files 3009 3009
Lines 90818 90820 +2
Branches 16877 16877
==========================================
Hits 32166 32166
- Misses 56185 56187 +2
Partials 2467 2467 ☔ View full report in Codecov by Sentry. |
rr-bw
requested changes
Feb 3, 2025
apps/web/src/app/components/environment-selector/environment-selector.component.html
Outdated
Show resolved
Hide resolved
libs/angular/src/auth/components/environment-selector.component.html
Outdated
Show resolved
Hide resolved
libs/angular/src/auth/components/environment-selector.component.html
Outdated
Show resolved
Hide resolved
libs/angular/src/auth/components/environment-selector.component.html
Outdated
Show resolved
Hide resolved
libs/angular/src/auth/components/environment-selector.component.html
Outdated
Show resolved
Hide resolved
…vironment-selector-component
…elector-component' of https://github.com/bitwarden/clients into auth/pm-17182/remove-bootstrap-style-from-environment-selector-component
rr-bw
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17182?atlOrigin=eyJpIjoiYmExMzNhNDU4N2E2NGRjYjhiNWVkMTJhNGY0ZTJjODQiLCJwIjoiaiJ9
📔 Objective
Remove Bootstrap styles from the EnvironmentSelectorComponent component.
📸 Screenshots
GMT20250131-214636_Clip_Alec.Rippberger.s.Clip.01_31_2025.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes