Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-17963 remove ts ignore from bar.ts #13249

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dan-livefront
Copy link
Collaborator

@dan-livefront dan-livefront commented Feb 4, 2025

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-17963

๐Ÿ“” Objective

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@dan-livefront dan-livefront changed the title PM-17963 create setattribute function to apply where relevant in ordeโ€ฆ PM-17963 remove ts ignore from bar.ts Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ e27d005d-03ee-4c12-936c-fd5ab4ef201b

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 35.41%. Comparing base (2c36744) to head (dd2e7b0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
apps/browser/src/autofill/notification/bar.ts 0.00% 58 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13249      +/-   ##
==========================================
+ Coverage   35.39%   35.41%   +0.02%     
==========================================
  Files        3009     3009              
  Lines       90783    90834      +51     
  Branches    16868    16890      +22     
==========================================
+ Hits        32130    32170      +40     
- Misses      56189    56197       +8     
- Partials     2464     2467       +3     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant